Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Chore][Autoscaler] Clarify disable_launch_config_check comment in StandardAutoscaler#51751

Merged
jjyao merged 1 commit intoray-project:masterfromnadongjun:autoscaler/comment
Mar 27, 2025

Conversation

nadongjun
Copy link
Contributor

Why are these changes needed?

  • This pull request updates the comment for the disable_launch_config_check setting in autoscaler.py to provide a clearer explanation, aligning it with the description found inscheduler.py.
  • The goal is to clarify the purpose of the disable_launch_config_check setting specifically in the context of StandardAutoscaler. This change enhances the understanding of its purpose and usage scenarios.
  • Additionally, if logs are required when disable_launch_config_check is enabled, similar to the behavior in scheduler.py, they will be added to functions in autoscaler.py. This change improves clarity regarding its purpose and usage scenarios.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@nadongjunnadongjun requested a review froma team as acode ownerMarch 27, 2025 10:55
@jjyaojjyao added the goadd ONLY when ready to merge, run all tests labelMar 27, 2025
@jjyaojjyao merged commit84b1293 intoray-project:masterMar 27, 2025
3 of 5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jjyaojjyaojjyao approved these changes

Assignees
No one assigned
Labels
goadd ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nadongjun@jjyao

[8]ページ先頭

©2009-2025 Movatter.jp