- Notifications
You must be signed in to change notification settings - Fork6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[CI] Add ability to configure release tests with a matrix#51721
Conversation
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(this is changed to draft. is it ready for review now?)
Not yet, realized there were a few review comments I missed. Will ping you when ready |
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@aslonnie okay, should be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why are these changes needed?
To ensure Ray Data works performantly in a wide range of scenarios, we want to run release tests with many variants. For example, for our aggregation release tests, we want to run release tests with and without autoscaling, with different cardinalities, and with different implementations.
To decrease the maintenance cost and improve the readability of the release test config, this PR introduces a matrix syntax based onBuildkite's.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.