Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[ci] upgrade rayci version#51713

Merged
aslonnie merged 7 commits intomasterfromlonnie-250326-rayciup
Mar 28, 2025
Merged

[ci] upgrade rayci version#51713

aslonnie merged 7 commits intomasterfromlonnie-250326-rayciup
Mar 28, 2025

Conversation

aslonnie
Copy link
Collaborator

  • printing out rayci step id
  • stop always running steps with no tags on premerge
  • supports selecting with tags

- printing out rayci step id- stop always running steps with no tags on premerge- supports selecting with tagsSigned-off-by: Lonnie Liu <lonnie@anyscale.com>
Copy link
Collaborator

@edoakesedoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

always will run independent of conditional testing logic?

@aslonnie
Copy link
CollaboratorAuthor

always will run independent of conditional testing logic?

it is more like conditional test logic will always emit the "always" tag.

before this change, it will always emit the "lint" tag, and I worry that people will just start to use "lint" to mean "always", even when the test job is not "lint"

edoakes reacted with thumbs up emoji

@aslonnie
Copy link
CollaboratorAuthor

always will run independent of conditional testing logic?

it is more like conditional test logic will always emit the "always" tag.

before this change, it will always emit the "lint" tag, and I worry that people will just start to use "lint" to mean "always", even when the test job is not "lint"

actually, this is the change that adds the "always" tag in conditional testing:
#51662

for this change, the new version ofrayci will not auto run steps that do not have "tags" (the old version treated those steps as having the "always" tag). this will make it that the default behavior for a new test job is to not run on any premerge, and people need to add a proper tag to enable proper conditional testing. test jobs with no tag will still run in postmerge, so if they are broken/easy to break by changes, we can easily tell and add proper tags as follow ups.

if test/jobs with no tags happen really frequently, I can also add a test that tests that all buildkite test jobs has a tag as follow up.. we will see.

this upgrade will hopefully save some test costs, by largely speaking only running tests that matter the most.

@aslonnieaslonnie added the goadd ONLY when ready to merge, run all tests labelMar 26, 2025
@aslonnieaslonnie merged commit3da4bcb intomasterMar 28, 2025
5 checks passed
@aslonnieaslonnie deleted the lonnie-250326-rayciup branchMarch 28, 2025 01:08
pavelkushtia pushed a commit to pavelkushtia/ray that referenced this pull requestApr 6, 2025
- printing out rayci step id- stop always running steps with no tags on premerge- supports selecting with tagsSigned-off-by: Lonnie Liu <lonnie@anyscale.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@edoakesedoakesedoakes approved these changes

@khluukhluuAwaiting requested review from khluu

Assignees
No one assigned
Labels
goadd ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslonnie@edoakes

[8]ページ先頭

©2009-2025 Movatter.jp