- Notifications
You must be signed in to change notification settings - Fork6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[ci] upgrade rayci version#51713
Conversation
aslonnie commentedMar 26, 2025
- printing out rayci step id
- stop always running steps with no tags on premerge
- supports selecting with tags
- printing out rayci step id- stop always running steps with no tags on premerge- supports selecting with tagsSigned-off-by: Lonnie Liu <lonnie@anyscale.com>
7e2953d
to62a793e
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
always
will run independent of conditional testing logic?
it is more like conditional test logic will always emit the "always" tag. before this change, it will always emit the "lint" tag, and I worry that people will just start to use "lint" to mean "always", even when the test job is not "lint" |
actually, this is the change that adds the "always" tag in conditional testing: for this change, the new version of if test/jobs with no tags happen really frequently, I can also add a test that tests that all buildkite test jobs has a tag as follow up.. we will see. this upgrade will hopefully save some test costs, by largely speaking only running tests that matter the most. |
- printing out rayci step id- stop always running steps with no tags on premerge- supports selecting with tagsSigned-off-by: Lonnie Liu <lonnie@anyscale.com>