Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Test][KubeRay] Add a deliberate failure test to ensure doctests fail on error#51709

Conversation

MortalHappiness
Copy link
Member

@MortalHappinessMortalHappiness commentedMar 26, 2025
edited
Loading

Why are these changes needed?

As title.

image

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@MortalHappinessMortalHappiness added the goadd ONLY when ready to merge, run all tests labelMar 26, 2025
… on errorSigned-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappinessMortalHappinessforce-pushed thefeature/deliberate-kuberay-doctest-failure branch fromd221bec tobc78595CompareMarch 26, 2025 11:26
@MortalHappinessMortalHappiness marked this pull request as ready for reviewMarch 26, 2025 11:41
@MortalHappiness
Copy link
MemberAuthor

cc@rueian

@kevin85421
Copy link
Member

@jjyao@edoakes would you mind merging this PR? Thanks!

@jjyaojjyao merged commit00de814 intoray-project:masterMar 28, 2025
5 checks passed
pavelkushtia pushed a commit to pavelkushtia/ray that referenced this pull requestApr 6, 2025
… on error (ray-project#51709)Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rueianrueianrueian approved these changes

@kevin85421kevin85421kevin85421 approved these changes

Labels
goadd ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@MortalHappiness@kevin85421@rueian@jjyao@edoakes

[8]ページ先頭

©2009-2025 Movatter.jp