- Notifications
You must be signed in to change notification settings - Fork6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[core]test_job_isolation passes even when exceptions are thrown#51694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
test_job_isolation always passes although it always failstest_job_isolation always passes even if it always failstest_job_isolation always passes even if it always failstest_job_isolation always passes even if it exceptions are throwntest_job_isolation always passes even if it exceptions are throwntest_job_isolation always passes even when exceptions are thrown| @@ -56,14 +56,12 @@ def test_invalid_gcs_address(): | |||
| JobSubmissionClient("abc:abc") | |||
| @pytest.mark.skipif( | |||
| sys.version_info >= (3, 12), reason="lib is not supported on Python 3.12" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lib is the Python file we created for this test. I don't know why it says thatlib is not supported on Python 3.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lol
test_job_isolation always passes even when exceptions are throwntest_job_isolation passes even when exceptions are thrownedoakes approved these changesMar 26, 2025
dhakshin32 pushed a commit to dhakshin32/ray that referenced this pull requestMar 27, 2025
…ay-project#51694)`call_ray_start` uses an unusual method to obtain the GCS address. Itexecutes a `ray start` command and then parses the command's STDOUT.However, this method will return "None" as address. See the followingscreenshot for more details.https://github.com/ray-project/ray/blob/a5bab234e651d19b91d5860be0606d4c6c01d118/python/ray/tests/conftest.py#L771-L789---------Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
srinathk10 pushed a commit that referenced this pull requestMar 28, 2025
…51694)`call_ray_start` uses an unusual method to obtain the GCS address. Itexecutes a `ray start` command and then parses the command's STDOUT.However, this method will return "None" as address. See the followingscreenshot for more details.https://github.com/ray-project/ray/blob/a5bab234e651d19b91d5860be0606d4c6c01d118/python/ray/tests/conftest.py#L771-L789---------Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
call_ray_startuses an unusual method to obtain the GCS address. It executes aray startcommand and then parses the command's STDOUT. However, this method will return "None" as address. See the following screenshot for more details.ray/python/ray/tests/conftest.py
Lines 771 to 789 ina5bab23
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.