- Notifications
You must be signed in to change notification settings - Fork6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix Ray Client when 'uv run' runtime environment is used#51683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
edoakes approved these changesMar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
add test?
dhakshin32 pushed a commit to dhakshin32/ray that referenced this pull requestMar 27, 2025
…#51683)<!-- Thank you for your contribution! Please reviewhttps://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst beforeopening a pull request. --><!-- Please add a reviewer to the assignee section when you create a PR.If you don't have the access to it, we will shortly find a reviewer andassign them to your PR. -->## Why are these changes needed?Fixesray-project#51368The problem was happening because we check the command line of the RayClient server, but when used with `py_executable` equal to `uv run`, thecommand line would be `uv run -m ray.util.client.server ...` and not`python -m ray.util.client.server`, so the check needed to be adapted.## Related issue number<!-- For example: "Closesray-project#1234" -->## Checks- [ ] I've signed off every commit(by using the -s flag, i.e., `gitcommit -s`) in this PR.- [ ] I've run `scripts/format.sh` to lint the changes in this PR.- [ ] I've included any doc changes needed forhttps://docs.ray.io/en/master/.- [ ] I've added any new APIs to the API Reference. For example, if Iadded amethod in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file.- [ ] I've made sure the tests are passing. Note that there might be afew flaky tests, see the recent failures athttps://flakey-tests.ray.io/- Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
d-miketa pushed a commit to d-miketa/ray that referenced this pull requestMar 28, 2025
…#51683)<!-- Thank you for your contribution! Please reviewhttps://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst beforeopening a pull request. --><!-- Please add a reviewer to the assignee section when you create a PR.If you don't have the access to it, we will shortly find a reviewer andassign them to your PR. -->## Why are these changes needed?Fixesray-project#51368The problem was happening because we check the command line of the RayClient server, but when used with `py_executable` equal to `uv run`, thecommand line would be `uv run -m ray.util.client.server ...` and not`python -m ray.util.client.server`, so the check needed to be adapted.## Related issue number<!-- For example: "Closesray-project#1234" -->## Checks- [ ] I've signed off every commit(by using the -s flag, i.e., `gitcommit -s`) in this PR.- [ ] I've run `scripts/format.sh` to lint the changes in this PR.- [ ] I've included any doc changes needed forhttps://docs.ray.io/en/master/.- [ ] I've added any new APIs to the API Reference. For example, if Iadded amethod in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file.- [ ] I've made sure the tests are passing. Note that there might be afew flaky tests, see the recent failures athttps://flakey-tests.ray.io/- Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(
srinathk10 pushed a commit that referenced this pull requestMar 28, 2025
<!-- Thank you for your contribution! Please reviewhttps://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst beforeopening a pull request. --><!-- Please add a reviewer to the assignee section when you create a PR.If you don't have the access to it, we will shortly find a reviewer andassign them to your PR. -->## Why are these changes needed?Fixes#51368The problem was happening because we check the command line of the RayClient server, but when used with `py_executable` equal to `uv run`, thecommand line would be `uv run -m ray.util.client.server ...` and not`python -m ray.util.client.server`, so the check needed to be adapted.## Related issue number<!-- For example: "Closes#1234" -->## Checks- [ ] I've signed off every commit(by using the -s flag, i.e., `gitcommit -s`) in this PR.- [ ] I've run `scripts/format.sh` to lint the changes in this PR.- [ ] I've included any doc changes needed forhttps://docs.ray.io/en/master/.- [ ] I've added any new APIs to the API Reference. For example, if Iadded amethod in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file.- [ ] I've made sure the tests are passing. Note that there might be afew flaky tests, see the recent failures athttps://flakey-tests.ray.io/- Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :(Signed-off-by: Srinath Krishnamachari <srinath.krishnamachari@anyscale.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes#51368
The problem was happening because we check the command line of the Ray Client server, but when used with
py_executableequal touv run, the command line would beuv run -m ray.util.client.server ...and notpython -m ray.util.client.server, so the check needed to be adapted.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.