Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Serve.llm] Add gen config related doc#51572

Merged
zcin merged 5 commits intoray-project:masterfromGeneDer:add-gen-config-doc
Mar 21, 2025

Conversation

GeneDer
Copy link
Contributor

Why are these changes needed?

Add gen config related doc

Related issue number

Closeshttps://anyscale1.atlassian.net/browse/LLM-1786?atlOrigin=eyJpIjoiZDg2MWMxNmU0YTY2NDRhMGJiN2JmNDk0NmNjYjE3OWIiLCJwIjoiaiJ9

Checks

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDerGeneDer marked this pull request as ready for reviewMarch 21, 2025 15:40
@GeneDerGeneDer added the goadd ONLY when ready to merge, run all tests labelMar 21, 2025
@GeneDer
Copy link
ContributorAuthor

@kouroshHakha
Copy link
Contributor

@kouroshHakha can you do a first passhttps://anyscale-ray--51572.com.readthedocs.build/en/51572/serve/llm/serving-llms.html#generate-config-files

Looks good. Just that the hyperlink does not look good:
image

Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer
Copy link
ContributorAuthor

@kouroshHakha can you do a first passhttps://anyscale-ray--51572.com.readthedocs.build/en/51572/serve/llm/serving-llms.html#generate-config-files

Looks good. Just that the hyperlink does not look good:image

thanks! yea just realized this is not markdown file XD

Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Su <e870252314@gmail.com>
@GeneDer
Copy link
ContributorAuthor

@zcinzcin merged commit28d782d intoray-project:masterMar 21, 2025
5 checks passed
dhakshin32 pushed a commit to dhakshin32/ray that referenced this pull requestMar 27, 2025
<!-- Thank you for your contribution! Please reviewhttps://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst beforeopening a pull request. --><!-- Please add a reviewer to the assignee section when you create a PR.If you don't have the access to it, we will shortly find a reviewer andassign them to your PR. -->## Why are these changes needed?Add gen config related doc## Related issue numberCloseshttps://anyscale1.atlassian.net/browse/LLM-1786?atlOrigin=eyJpIjoiZDg2MWMxNmU0YTY2NDRhMGJiN2JmNDk0NmNjYjE3OWIiLCJwIjoiaiJ9## Checks- [ ] I've signed off every commit(by using the -s flag, i.e., `gitcommit -s`) in this PR.- [ ] I've run `scripts/format.sh` to lint the changes in this PR.- [ ] I've included any doc changes needed forhttps://docs.ray.io/en/master/.- [ ] I've added any new APIs to the API Reference. For example, if Iadded amethod in Tune, I've added it in `doc/source/tune/api/` under the           corresponding `.rst` file.- [ ] I've made sure the tests are passing. Note that there might be afew flaky tests, see the recent failures athttps://flakey-tests.ray.io/- Testing Strategy   - [ ] Unit tests   - [ ] Release tests   - [ ] This PR is not tested :(---------Signed-off-by: Gene Su <e870252314@gmail.com>Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zcinzcinzcin approved these changes

@kouroshHakhakouroshHakhakouroshHakha approved these changes

@edoakesedoakesAwaiting requested review from edoakesedoakes is a code owner

@akshay-anyscaleakshay-anyscaleAwaiting requested review from akshay-anyscaleakshay-anyscale is a code owner

Assignees

@kouroshHakhakouroshHakha

Labels
goadd ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@GeneDer@kouroshHakha@zcin

[8]ページ先頭

©2009-2025 Movatter.jp