- Notifications
You must be signed in to change notification settings - Fork6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[release-automation] Add option to add build tag when uploading wheels to pypi#51517
Conversation
| @@ -82,6 +82,7 @@ def download_ray_wheels_from_s3( | |||
| commit_hash: The commit hash of the green commit. | |||
| ray_version: The version of Ray. | |||
| directory_path: The directory to download the wheels to. | |||
| build_tag: The build tag to add to the downloaded wheels. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
where is this arg? wrong place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh yes it used to be there before I moved it.. but I forgot to delete the docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice!
could you fix the lints?
…s to pypi (ray-project#51517)- Add helper function to add build tag (e.g. `-1`) right after Rayversion in the wheel name, in cases where original wheels uploaded topypi/test pypi are corrupted.---------Signed-off-by: kevin <kevin@anyscale.com>Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
-1) right after Ray version in the wheel name, in cases where original wheels uploaded to pypi/test pypi are corrupted.