Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Serve] Improve serve deploy ignore behavior#49336

Open
bhmiller wants to merge5 commits intoray-project:master
base:master
Choose a base branch
Loading
frombhmiller:fix-serve-deploy-help

Conversation

bhmiller
Copy link
Contributor

Add to help text more fully in serve deploy when
an argument is ignored. Previously it was only
mentioned on the--name argument. Also adding
cli warning when user does specify these.

Why are these changes needed?

I wasted a lot of time trying to understand why my serve application
was not picking up passed in runtime env. It was silently ignoring, and
the behavior was undocumented, which I only found out by going to
source.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • Manually validated via localsetup-dev
      withserve deploy --help to check documentation and then callingserve deploy
      with a config file and other flags to check printed warning text.

Add to help text more fully in serve deploy whenan argument is ignored. Previously it was onlymentioned on the `--name` argument. Also addingcli warning when user does specify these.Signed-off-by: Brendan Miller <6900229+bhmiller@users.noreply.github.com>
@jcotant1jcotant1 added enhancementRequest for new feature and/or capability triageNeeds triage (eg: priority, bug/not-bug, and owning component) serveRay Serve Related Issue and removed enhancementRequest for new feature and/or capability triageNeeds triage (eg: priority, bug/not-bug, and owning component) labelsDec 18, 2024
@staleStale
Copy link

stalebot commentedFeb 25, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stalestalebot added the staleThe issue is stale. It will be closed within 7 days unless there are further conversation labelFeb 25, 2025
@stalestalebot removed the staleThe issue is stale. It will be closed within 7 days unless there are further conversation labelMar 28, 2025
@hainesmichaelchainesmichaelc added the community-contributionContributed by the community labelApr 4, 2025
Copy link
Contributor

@zcinzcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution@bhmiller! Sorry for the late review, this PR slipped through the cracks.

bhmiller reacted with thumbs up emoji
@zcinzcin added the goadd ONLY when ready to merge, run all tests labelApr 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zcinzcinzcin approved these changes

Assignees
No one assigned
Labels
community-contributionContributed by the communitygoadd ONLY when ready to merge, run all testsserveRay Serve Related Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@bhmiller@zcin@hainesmichaelc@jcotant1

[8]ページ先頭

©2009-2025 Movatter.jp