- Notifications
You must be signed in to change notification settings - Fork6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Serve] Improve serve deploy ignore behavior#49336
Open
bhmiller wants to merge5 commits intoray-project:masterChoose a base branch frombhmiller:fix-serve-deploy-help
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add to help text more fully in serve deploy whenan argument is ignored. Previously it was onlymentioned on the `--name` argument. Also addingcli warning when user does specify these.Signed-off-by: Brendan Miller <6900229+bhmiller@users.noreply.github.com>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
zcin approved these changesApr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for your contribution@bhmiller! Sorry for the late review, this PR slipped through the cracks.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
community-contributionContributed by the community goadd ONLY when ready to merge, run all tests serveRay Serve Related Issue
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add to help text more fully in serve deploy when
an argument is ignored. Previously it was only
mentioned on the
--name
argument. Also addingcli warning when user does specify these.
Why are these changes needed?
I wasted a lot of time trying to understand why my serve application
was not picking up passed in runtime env. It was silently ignoring, and
the behavior was undocumented, which I only found out by going to
source.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.with
serve deploy --help
to check documentation and then callingserve deploy
with a config file and other flags to check printed warning text.