Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[data] feat: Implementray.data.Dataset.offset#49274

Open
sumanthratna wants to merge3 commits intoray-project:master
base:master
Choose a base branch
Loading
fromsumanthratna:ray-data-offset

Conversation

sumanthratna
Copy link
Member

@sumanthratnasumanthratna commentedDec 15, 2024
edited
Loading

CC@neilshah12 and@richardliaw

Why are these changes needed?

This allows Ray Data users to callds.offset on their datasets. This feature corresponds to SQL'sOFFSET feature.This feature is useful, e.g., for implementing pagination on a dataset (in conjunction withds.limit).

Notes

  • should we detectoffset < 0 and raiseValueError?
  • should we detectoffset is None and raiseValueError?
    • another option: detectNone and treat this asoffset == 0. This more closely aligns with SQL syntax.
  • are we missing any test coverage?

Related issue number

n/a

Checks

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Sumanth Ratna <sumanth.ratna@yale.edu>
Signed-off-by: Sumanth Ratna <sumanth.ratna@yale.edu>
Signed-off-by: Sumanth Ratna <sumanth.ratna@yale.edu>
@jcotant1jcotant1 added the dataRay Data-related issues labelDec 16, 2024
@staleStale
Copy link

stalebot commentedJan 22, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stalestalebot added the staleThe issue is stale. It will be closed within 7 days unless there are further conversation labelJan 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@richardliawrichardliawAwaiting requested review from richardliaw

At least 1 approving review is required to merge this pull request.

Assignees

@richardliawrichardliaw

Labels
dataRay Data-related issuesstaleThe issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sumanthratna@richardliaw@jcotant1

[8]ページ先頭

©2009-2025 Movatter.jp