I was trying to read the logs of a Ray job via the sockets. Despite using sockets, and ensuring that we poll the socket on regular intervals, we realised that the socket closes after the transfer of exactly 4096KBs. After multiple trials, realised that its the logs for the socket that closes after this limit. Needed to ensure that sockets are not closed for long running heavy jobs.

Related issue number

Checks

[-] I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
I've runscripts/format.sh to lint the changes in this PR.
I've included any doc changes needed forhttps://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it indoc/source/tune/api/ under the
  corresponding.rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

removed limit on log sizes

2c6d6e7

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>

mohitjain2504 changed the title~~removed limit on log sizes~~removed limit on log sizes via sockets

Nov 18, 2024

mohitjain2504 added2 commits

November 18, 2024 19:15

fixed lint checks

861cecd

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>

fixed linting checks

63ed6bb

Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>

jcotant1 added the coreIssues that should be addressed in Ray Core label

Nov 18, 2024

Merge branch 'master' into fix_log_socket_message_size

31e87ca

kevin85421 added jobs and removed coreIssues that should be addressed in Ray Core labels

Dec 2, 2024

Copy link

stalebot commentedJan 31, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.