- Notifications
You must be signed in to change notification settings - Fork6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[doc] minor/patch version update#48626
base:master
Are you sure you want to change the base?
Conversation
Extend explicitly on the documentation that the Python versions of client and server must match up to the Patch version.Signed-off-by: Eduardo Ochetski Hellas <ehellas@gmail.com>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
| @@ -248,7 +248,7 @@ Versioning requirements | |||
| Generally, the client Ray version must match the server Ray version. An error will be raised if an incompatible version is used. | |||
| Similarly, the minorPython(e.g., 3.6 vs 3.7) must match between the client and server. An error will be raised if this is not the case. | |||
| Similarly, the minor (e.g., 3.6 vs 3.7) and patch (e.g. 3.7.17 vs 3.7.16) Python versions must match between the client and server. An error will be raised if this is not the case. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For ray client I think we don't consider patch version:
def _check_versions(self, conn_info: Dict[str, Any], ignore_version: bool) -> None: # conn_info has "python_version" and "ray_version" so it can be used to compare. ignore_version = ignore_version or ("RAY_IGNORE_VERSION_MISMATCH" in os.environ) check_version_info( conn_info, "Ray Client", raise_on_mismatch=not ignore_version, python_version_match_level="minor", )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you dig into this a little deeper? I recently saw an error message
Call to `ray.init()` on the server failed with: Version mismatch: The cluster was started with: Ray: 2.44.0 Python: 3.12.3This process on node 127.0.0.1 was started with: Ray: 2.44.0 Python: 3.12.8which seems to indicate that's actually not the case -- there might be a bug :)
Extend explicitly on the documentation that the Python versions of client and server must match up to the Patch version.
Thiscloses#45339