Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Docs][Collective] Fix examples to use init_collective_group and create_collective_group#48570

Open
arcyleung wants to merge2 commits intoray-project:master
base:master
Choose a base branch
Loading
fromarcyleung:collective-docs

Conversation

arcyleung
Copy link

@arcyleungarcyleung commentedNov 5, 2024
edited
Loading

Why are these changes needed?

Update ray-collective rst docs to show working example. Usecreate_collective_group instead ofdeclare_collective_group, since it appears to be out of date in the latest doc pagehttps://docs.ray.io/en/latest/ray-more-libs/ray-collective.html

Related issue number

N/A

Checks

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
    • Manual testing

@arcyleungarcyleung requested a review froma team as acode ownerNovember 5, 2024 19:26
@arcyleungarcyleung changed the title[Core][Doc] Fix examples to use init_collective_group and create_collective_group[Docs][Core] Fix examples to use init_collective_group and create_collective_groupNov 5, 2024
@arcyleungarcyleung changed the title[Docs][Core] Fix examples to use init_collective_group and create_collective_group[Docs][Collective] Fix examples to use init_collective_group and create_collective_groupNov 5, 2024
Signed-off-by: Arthur Leung <arthur.leung1@huawei.com>
@staleStale
Copy link

stalebot commentedFeb 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stalestalebot added the staleThe issue is stale. It will be closed within 7 days unless there are further conversation labelFeb 1, 2025
@jcotant1jcotant1 added the docsAn issue or change related to documentation labelMar 26, 2025
@stalestalebot removed the staleThe issue is stale. It will be closed within 7 days unless there are further conversation labelMar 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docsAn issue or change related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@arcyleung@jcotant1

[8]ページ先頭

©2009-2025 Movatter.jp