Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Doc][KubeRay] Document Fields that Will Not Trigger Downtime in RayService#47561

Open
Yicheng-Lu-llll wants to merge1 commit intoray-project:master
base:master
Choose a base branch
Loading
fromYicheng-Lu-llll:patch-1

Conversation

Yicheng-Lu-llll
Copy link
Contributor

@Yicheng-Lu-llllYicheng-Lu-llll commentedSep 9, 2024•
edited
Loading

Why are these changes needed?

As title. In latest KubeRay, the fieldsminReplicas andmaxReplicas are excluded from the hash calculation for RayCluster updates. As a result, even if users modify these fields, the calculated hash remains unchanged, meaning no update or rolling restart will occur.

Seeray-project/kuberay#2172 for more detail.

Related issue number

Checks

image

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Yicheng-Lu-llll <51814063+Yicheng-Lu-llll@users.noreply.github.com>
@Yicheng-Lu-llllYicheng-Lu-llll changed the title[Doc][KubeRay] [Doc][KubeRay] Document Fields that Will Not Trigger Downtime in RayService[Doc][KubeRay] Document Fields that Will Not Trigger Downtime in RayServiceSep 9, 2024
@anyscalesamanyscalesam added docsAn issue or change related to documentation kuberayIssues for the Ray/Kuberay integration that are tracked on the Ray side triageNeeds triage (eg: priority, bug/not-bug, and owning component) labelsSep 16, 2024
@angelinalg
Copy link
Contributor

@kevin85421, would you mind approving from a technical perspective?

@hainesmichaelchainesmichaelc added the community-contributionContributed by the community labelApr 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@angelinalgangelinalgangelinalg approved these changes

@architkulkarniarchitkulkarniAwaiting requested review from architkulkarni

@maxpumperlamaxpumperlaAwaiting requested review from maxpumperla

@pcmoritzpcmoritzAwaiting requested review from pcmoritzpcmoritz is a code owner

@kevin85421kevin85421Awaiting requested review from kevin85421kevin85421 is a code owner

Assignees

@kevin85421kevin85421

Labels
community-contributionContributed by the communitydocsAn issue or change related to documentationkuberayIssues for the Ray/Kuberay integration that are tracked on the Ray sidetriageNeeds triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@Yicheng-Lu-llll@angelinalg@kevin85421@hainesmichaelc@anyscalesam
[8]ページ先頭
©2009-2025 Movatter.jp