- Notifications
You must be signed in to change notification settings - Fork6.6k
[autoscaler] Usebash
instead of/bin/bash
#38105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
bash
instead of/bin/bash
Signed-off-by: Rowan Skewes <rowan.skewes@gmail.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -408,7 +408,7 @@ def create_and_get_archive_from_remote_node( | ||
else ["--no-proccesses-verbose"] | ||
) | ||
cmd += ["bash", "-c", _wrap(collect_cmd, quotes='"')] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. this might create security issue to hijacking bash via maybe the path of bash (or all shell?) should be an configurable option. | ||
cat = "node" if not remote_node.is_head else "head" | ||