Aug 3, 2023 · Aug 6, 2024 · Aug 20, 2024
diff --git a/python/ray/autoscaler/_private/cluster_dump.py b/python/ray/autoscaler/_private/cluster_dump.py
            else ["--no-proccesses-verbose"]
        )

    cmd += ["/bin/bash", "-c", _wrap(collect_cmd, quotes='"')]
    cmd += ["bash", "-c", _wrap(collect_cmd, quotes='"')]

    cat = "node" if not remote_node.is_head else "head"

diff --git a/python/ray/autoscaler/_private/command_runner.py b/python/ray/autoscaler/_private/command_runner.py
            .replace("ssh", "ssh -tt", 1)
            .strip("\n")
        )
        return inner_str + " {} exec -it {}/bin/bash\n".format(
        return inner_str + " {} exec -it {} bash\n".format(
            self.docker_cmd, self.container_name
        )

diff --git a/python/ray/autoscaler/_private/docker.py b/python/ray/autoscaler/_private/docker.py
    if env_vars:
        env_str = " ".join(["-e {env}=${env}".format(env=env) for env in env_vars])
    return [
        "docker exec {interactive} {env} {container}/bin/bash -c {cmd} ".format(
        "docker exec {interactive} {env} {container} bash -c {cmd} ".format(
            interactive="-it" if with_interactive else "",
            env=env_str,
            container=container_name,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -408,7 +408,7 @@ def create_and_get_archive_from_remote_node(
		else ["--no-proccesses-verbose"]
		)

		cmd += ["/bin/bash", "-c", _wrap(collect_cmd, quotes='"')]
		cmd += ["bash", "-c", _wrap(collect_cmd, quotes='"')]
Copy link Collaborator aslonnieAug 20, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. this might create security issue to hijacking bash via`PATH`? maybe the path of bash (or all shell?) should be an configurable option.

		cat = "node" if not remote_node.is_head else "head"

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -582,7 +582,7 @@ def remote_shell_command_str(self):
		.replace("ssh", "ssh -tt", 1)
		.strip("\n")
		)
		return inner_str + " {} exec -it {}/bin/bash\n".format(
		return inner_str + " {} exec -it {} bash\n".format(
		self.docker_cmd, self.container_name
		)

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -54,7 +54,7 @@ def with_docker_exec(
		if env_vars:
		env_str = " ".join(["-e {env}=${env}".format(env=env) for env in env_vars])
		return [
		"docker exec {interactive} {env} {container}/bin/bash -c {cmd} ".format(
		"docker exec {interactive} {env} {container} bash -c {cmd} ".format(
		interactive="-it" if with_interactive else "",
		env=env_str,
		container=container_name,
Expand Down