Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[autoscaler] Usebash instead of/bin/bash#38105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
rskew wants to merge1 commit intoray-project:masterfromrskew:no-bin-bash
Closed
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[autoscaler] Usebash instead of/bin/bash
Signed-off-by: Rowan Skewes <rowan.skewes@gmail.com>
  • Loading branch information
@rskew
rskew committedAug 6, 2024
commit306cb514654bf86e0fed051ee01a9a13bc058b3d
2 changes: 1 addition & 1 deletionpython/ray/autoscaler/_private/cluster_dump.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -408,7 +408,7 @@ def create_and_get_archive_from_remote_node(
else ["--no-proccesses-verbose"]
)

cmd += ["/bin/bash", "-c", _wrap(collect_cmd, quotes='"')]
cmd += ["bash", "-c", _wrap(collect_cmd, quotes='"')]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this might create security issue to hijacking bash viaPATH?

maybe the path of bash (or all shell?) should be an configurable option.


cat = "node" if not remote_node.is_head else "head"

Expand Down
2 changes: 1 addition & 1 deletionpython/ray/autoscaler/_private/command_runner.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -582,7 +582,7 @@ def remote_shell_command_str(self):
.replace("ssh", "ssh -tt", 1)
.strip("\n")
)
return inner_str + " {} exec -it {}/bin/bash\n".format(
return inner_str + " {} exec -it {} bash\n".format(
self.docker_cmd, self.container_name
)

Expand Down
2 changes: 1 addition & 1 deletionpython/ray/autoscaler/_private/docker.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ def with_docker_exec(
if env_vars:
env_str = " ".join(["-e {env}=${env}".format(env=env) for env in env_vars])
return [
"docker exec {interactive} {env} {container}/bin/bash -c {cmd} ".format(
"docker exec {interactive} {env} {container} bash -c {cmd} ".format(
interactive="-it" if with_interactive else "",
env=env_str,
container=container_name,
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp