NotificationsYou must be signed in to change notification settings
Fork6.2k
Star36.5k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

[autoscaler] Use`bash` instead of`/bin/bash`#38105

Closed

rskew wants to merge1 commit intoray-project:masterfromrskew:no-bin-bash

Closed

[autoscaler] Use`bash` instead of`/bin/bash`#38105

rskew wants to merge1 commit intoray-project:masterfromrskew:no-bin-bash

Conversation

Copy link

rskew commentedAug 4, 2023•
edited
Loading

Why are these changes needed?

Some Docker containers (e.g. from scratch containers, or containers built with nix) may not have/bin/bash included. Replacing/bin/bash withbash allows them to work.

It is already assumed thatbash will be on thePATH, e.g.docker run usesbash as the cmd:

ray/python/ray/autoscaler/_private/docker.py

Lines 115 to 127 ina32d29d

	docker_run= [
	docker_cmd,
	"run",
	"--rm",
	"--name {}".format(container_name),
	"-d",
	"-it",
	mount_flags,
	env_flags,
	user_options_str,
	"--net=host",
	image,
	"bash",

Related issue number

Checks

I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
I've runscripts/format.sh to lint the changes in this PR.
I've included any doc changes needed forhttps://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it indoc/source/tune/api/ under the
  corresponding.rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

I've run a cluster with this code and the cluster runs successfully.

rskew requested review fromwuisawesome,DmitriGekhtman,ericl anda team ascode owners

August 4, 2023 02:03

Copy link

Author

rskew commentedAug 30, 2023

Friendly bump :)

Copy link

stalebot commentedOct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stalebot added the staleThe issue is stale. It will be closed within 7 days unless there are further conversation label

Oct 15, 2023

rskew requested review fromarchitkulkarni andhongchaodeng ascode owners

December 25, 2023 04:13

stalebot removed the staleThe issue is stale. It will be closed within 7 days unless there are further conversation label

Dec 25, 2023

architkulkarni self-assigned this

Dec 26, 2023

anyscalesam added triage

Needs triage (eg: priority, bug/not-bug, and owning component)

coreIssues that should be addressed in Ray Core labels

May 15, 2024

anyscalesam added the core-autoscalerautoscaler related issues label

Jun 17, 2024

Copy link

Contributor

anyscalesam commentedJul 16, 2024

@hongchaodeng picking it back up post@architkulkarni ... this is safe to merge no?

Copy link

Contributor

anyscalesam commentedJul 16, 2024

@rskew can you fix the failing tests here so we can merge?

jjyao unassignedarchitkulkarni

Jul 29, 2024

[autoscaler] Usebash instead of/bin/bash

306cb51

Signed-off-by: Rowan Skewes <rowan.skewes@gmail.com>

rskew force-pushed theno-bin-bash branch from4a29ae9 to306cb51Compare

August 6, 2024 06:22

Copy link

Author

rskew commentedAug 11, 2024

@anyscalesam how do I get thebuildkite/premerge CI check to run?

anyscalesam added the goadd ONLY when ready to merge, run all tests label

Aug 12, 2024

Copy link

Contributor

anyscalesam commentedAug 12, 2024

ask one of the reviewers - we have rights to start it with the go label addition; i just added buildkite is running now@rskew

anyscalesam requested review fromaslonnie andcan-anyscale

August 19, 2024 21:39

anyscalesam added P1Issue that should be fixed within a few weeks and removed triageNeeds triage (eg: priority, bug/not-bug, and owning component) labels

Aug 19, 2024

aslonnie removed request forwuisawesome,DmitriGekhtman,aslonnie andcan-anyscale

August 20, 2024 03:09

aslonnie requested a review fromjjyao

August 20, 2024 03:09

aslonnie reviewed

Aug 20, 2024

View reviewed changes

Copy link

Collaborator

aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

core team owns this part.

python/ray/autoscaler/_private/cluster_dump.py

		@@ -408,7 +408,7 @@ def create_and_get_archive_from_remote_node(
		else ["--no-proccesses-verbose"]
		)

		cmd += ["/bin/bash", "-c", _wrap(collect_cmd, quotes='"')]
		cmd += ["bash", "-c", _wrap(collect_cmd, quotes='"')]