Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix incorrect Bazel dependency in host/hardware_irq#2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rhulme wants to merge1 commit intoraspberrypi:develop
base:develop
Choose a base branch
Loading
fromrhulme:host_hardware_irq_bazel

Conversation

@rhulme
Copy link
Contributor

Bazel configuration adds a dependency on hardware_claim in 'host' but it doesn't exist there. It's in 'common'.

Fixes#2738

Bazel configuration adds a dependency on hardware_claim in 'host' butit doesn't exist there.  It's in 'common'.Fixesraspberrypi#2738
Copy link
Contributor

@armandomontanezarmandomontanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Because of#2596, you might be able to removetags = ["manual"] from this too

@rhulme
Copy link
ContributorAuthor

rhulme commentedDec 3, 2025•
edited
Loading

Thanks! Because of#2596, you might be able to removetags = ["manual"] from this too

I haven't got my head around how exactly Bazel does things yet. I just tried running the command from the Bazel build checks (which seem to be permanently failing anyway).

I noticedhost/hardware_irq still has issues becausePICO_NUM_VTABLE_IRQS is not defined. That's not a Bazel issue directly, more a debug/release build issue. It seems that Bazel creates a debug build by default, so the assertion incheck_irq_param becomes 'live' and the compiler complains about the undefined value.

@lurch
Copy link
Contributor

I noticedhost/hardware_irq still has issues becausePICO_NUM_VTABLE_IRQS is not defined.

More PRs are always welcome! 😄

@rhulme
Copy link
ContributorAuthor

I noticedhost/hardware_irq still has issues becausePICO_NUM_VTABLE_IRQS is not defined.

More PRs are always welcome! 😄

I was trying to decide what the "right" way to fix it would be 😉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@armandomontanezarmandomontanezarmandomontanez approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhulme@lurch@armandomontanez
[8]ページ先頭
©2009-2025 Movatter.jp