- Notifications
You must be signed in to change notification settings - Fork22.1k
Remove unused instrumentation hooks from action_controller#43364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
eugeneius merged 1 commit intorails:mainfromyykamei:remove-unused-instrumentation-action_controller-hooksOct 3, 2021
Merged
Remove unused instrumentation hooks from action_controller#43364
eugeneius merged 1 commit intorails:mainfromyykamei:remove-unused-instrumentation-action_controller-hooksOct 3, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Instrumentation hooks for `write_page.action_controller` and`expire_page.action_controller` seem to be removedinrails#7833.So, subscribers for them are no longer necessary.
Member
eugeneius commentedOct 3, 2021
Thanks! I verified that these notifications never made it intohttps://github.com/rails/actionpack-action_caching, so it looks like you're right that they haven't worked since#7833. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Instrumentation hooks for
write_page.action_controllerandexpire_page.action_controllerseem to be removed in#7833. So, subscribers for them are no longer necessary.I think rails doesn't have to care about instrumentation hooks that are not provided by rails by subscribing to them in its core implementation.
Other Information
I searched the pattern including
write_pageandexpire_pagewith git-grep(1) and got the result like this: