- Notifications
You must be signed in to change notification settings - Fork22.1k
Include deserialized arguments in jobs returned by AJ test helpers#34204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rails-bot commentedOct 12, 2018
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from@sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues usingCode Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please seethe contribution instructions for more information. |
`assert_enqueued_with` and `assert_performed_with` return a instantiatedinstance of the matching job for further assertion (rails#21010).Before this commit the `arguments` method on the returned instancereturns a serialized version of the arguments.
gmcgibbon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To be clear, the previous behaviour would include activejob serialization data like[1, 2, 3, {"keyword"=>true, "_aj_symbol_keys"=>["keyword"]}] which isn't important when asserting arguments of a job. 👍
albertoalmagro left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@XrXr !
Include deserialized arguments in jobs returned by AJ test helpers
Summary
assert_enqueued_withandassert_performed_withreturn a instantiatedinstance of the matching job for further assertion (#21010).
Before this commit the
argumentmethod on the returned instancereturns a serialized version of the argument.