- Notifications
You must be signed in to change notification settings - Fork22.1k
Prefix Module#parent, Module#parents, and Module#parent_name with module#34051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
dhh commentedOct 2, 2018
I like this approach 👍 |
2f10932 toe013117Comparee013117 toc401c43Comparerafaelfranca added a commit that referenced this pull requestOct 2, 2018
Prefix Module#parent, Module#parents, and Module#parent_name with module
ruby-bench-server pushed a commit to tgxworld/rails that referenced this pull requestOct 3, 2018
y-yagi added a commit to y-yagi/rollbar-gem that referenced this pull requestJan 25, 2019
`Module#parent_name is` deprecated in Rails 6.0.Ref:rails/rails#34051
cars10 commentedMar 4, 2019
I upgraded my rails What is the recommended way to fix these? |
Contributor
kaspth commentedMar 4, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@cars10 reading the deprecation message it sounds like you have a |
cars10 commentedMar 4, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I do not have any calls to Edit: all deprecation warnings point to lines where |
katsuma added a commit to katsuma/garage_client that referenced this pull requestApr 29, 2019
Suppress DEPRECATION WARNING related this PR.rails/rails#34051
katsuma added a commit to katsuma/garage_client that referenced this pull requestApr 29, 2019
Suppress DEPRECATION WARNING related to [this changes](rails/rails#34051).
katsuma added a commit to katsuma/garage_client that referenced this pull requestApr 29, 2019
Suppress DEPRECATION WARNING related to [this changes](rails/rails#34051).
sinsoku added a commit to sinsoku/dd-trace-rb that referenced this pull requestMay 8, 2019
`parent_name` will be renamed `module_parent_name` in Rails 6.1,so it displays deprecation warnings on Rails 6.0.refs:rails/rails#34051
sinsoku added a commit to sinsoku/dd-trace-rb that referenced this pull requestMay 8, 2019
`parent_name` will be renamed `module_parent_name` in Rails 6.1,so it displays deprecation warnings on Rails 6.0.refs:rails/rails#34051
suketa added a commit to suketa/rails_sandbox that referenced this pull requestJun 15, 2019
Prefix Module#parent, Module#parents, and Module#parent_name with modulerails/rails#34051
suketa added a commit to suketa/rails_sandbox that referenced this pull requestJun 16, 2019
Prefix Module#parent, Module#parents, and Module#parent_name with modulerails/rails#34051
Contributor
leastbad commentedJun 30, 2019
The |
bwebster added a commit to stitchfix/stitches that referenced this pull requestSep 6, 2019
rails/rails#34051 deprecated .parent in-favorof using .module_parent. This commit updates the code to use thenew method, which should remove all of the deprecation warnings weare seeing when using rails v6.
agrobbin added a commit to agrobbin/rails-erd that referenced this pull requestSep 23, 2019
…dule#module_parent`Rails 6 deprecated `Module#parent` and friends inrails/rails#34051, replacing them with a `module_*`-prefix naming scheme. This checks to see if `module_parent` is defined, using it if it's available.
rubysamurai added a commit to rubysamurai/meta-rails that referenced this pull requestDec 14, 2020
PanosCodes added a commit to PanosCodes/mongoid that referenced this pull requestJan 5, 2021
Since Rails 6.0 the parent method is replaced with module_parentrails/rails#34051
3 tasks
yagince added a commit to yagince/erd that referenced this pull requestFeb 16, 2021
Rails 6 deprecated `Module#parent` and friends inrails/rails#34051, replacing them with a `module_*`-prefix naming scheme. This checks to see if `module_parent` is defined, using it if it's available.
kerrizor pushed a commit to voormedia/rails-erd that referenced this pull requestFeb 16, 2021
* silence deprecation warning from the rename of `Module#parent` to `Module#module_parent`Rails 6 deprecated `Module#parent` and friends inrails/rails#34051, replacing them with a `module_*`-prefix naming scheme. This checks to see if `module_parent` is defined, using it if it's available.* fix tests with hacky patch* comments* revert formatting changes* Fully support Rails 6.1 in tests* forgot to exclude several old versions of Ruby* fix indentation in blocksBig thanks to @andrew-newellCo-authored-by: Alex Robbin <agrobbin@gmail.com>
kennyadsl added a commit to solidusio-contrib/solidus_searchkick that referenced this pull requestApr 22, 2021
It changed in Rails withrails/rails#34051 and the old methodhas been deprecated and removed. This code should work with bothRails 5.2 and 6.1+
kennyadsl added a commit to solidusio-contrib/solidus_searchkick that referenced this pull requestApr 22, 2021
It changed in Rails withrails/rails#34051 and the old methodhas been deprecated and removed. This code should work with bothRails 5.2 and 6.1+
senid231 added a commit to senid231/didww-v3-ruby that referenced this pull requestOct 22, 2021
activesupport 6 has breaking change - parent* methods renamed to module_parent*.seerails/rails#34051
senid231 added a commit to senid231/didww-v3-ruby that referenced this pull requestOct 26, 2021
activesupport 6 has breaking change - parent* methods renamed to module_parent*.seerails/rails#34051
tagliala added a commit to ifad/hawk that referenced this pull requestJun 15, 2024
`parent` was needed to support Active Model < 6.1.Since the minimum required version is now 7.0, the conditional is notneeded anymoreRef:rails/rails#34051Close#12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
module_prefix toModule#parent,Module#parents, andModule#parent_name.As discussed in#20901,
parentsisn't a blacklisted class attribute for model scopes. Using aparentsscope will result in aSystemStackError.An alternate approach would be to disallow
parentsas a valid scope name, or find a better prefix thanmodule_because it can include classes which are technically modules but could be better represented.I'll look into fixing call sites once we decide what the best course of action is.
r?@rafaelfranca
/cc@dhh,@sgrif