- Notifications
You must be signed in to change notification settings - Fork22.1k
Refactor migrations_path command option to database#34021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
eileencodes merged 1 commit intorails:masterfromgmcgibbon:change_migrations_paths_command_option_to_dbSep 28, 2018
Merged
Refactor migrations_path command option to database#34021
eileencodes merged 1 commit intorails:masterfromgmcgibbon:change_migrations_paths_command_option_to_dbSep 28, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
eileencodes left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, but there's a test failing
15a23b9 to4775d3dCompareMemberAuthor
gmcgibbon commentedSep 28, 2018
Sorry about that, its 🍏 now! |
Member
eileencodes commentedSep 28, 2018
Thanks! |
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull requestOct 15, 2018
…ors [ci skip]`migrations_paths` option was added to migration generator, withchangelog entry, inrails#33760.Also `migrations_paths` option was added to model generator, withchangelog entry, inrails#33994.Then `migrations_paths` was renamed to `database` and aliased as `db`inrails#34021, and was added new changelog entry.I think we should edit existed changelog entries instead adding newabout changing the name of the option from `migrations_paths` to `database`since Rails 6.0 hasn't been released yet, and since It might confusereaders of the changelog file in case if they've read changelog enty aboutadding `migrations_paths` option but haven't read the entry aboutchange the name of that option to `database`.@eileencodes,@gmcgibbon,@rafaelfranca Does it make sense?
y-yagi added a commit to y-yagi/rails that referenced this pull requestMar 20, 2019
Thor automatically adds `-` if aliases do not start with `-`.https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L53But Thor follows a convention of one-dash-one-letter options.So, even if `-` is added to `db`, it does not work.https://github.com/erikhuda/thor/blob/0879c1773d188902d54f95174f33961ac33111f8/lib/thor/parser/options.rb#L4Follow uprails#34021.
suketa added a commit to suketa/rails_sandbox that referenced this pull requestJun 9, 2019
* [Add migrations_paths option to migration generator](rails/rails#33760)* [Add migrations_paths option to model generator](rails/rails#33994)* [Refactor migrations_path command option to database](rails/rails#34021)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
As discussed in#33994, refactors
migrations_pathscommand option in generators todatabase(aliased asdb). Now, the migrations paths will be read from the specified database configuration in the current environment.--databasecan be used with the migration, model, and scaffold generators.r?@eileencodes
/cc@rafaelfranca@kaspth