Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refactor migrations_path command option to database#34021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@gmcgibbon
Copy link
Member

@gmcgibbongmcgibbon commentedSep 28, 2018
edited
Loading

Summary

As discussed in#33994, refactorsmigrations_paths command option in generators todatabase (aliased asdb). Now, the migrations paths will be read from the specified database configuration in the current environment.

bin/rails g model Chair brand:string --database=kingston     invoke  active_record     create    db/kingston_migrate/20180830151055_create_chairs.rb

--database can be used with the migration, model, and scaffold generators.

r?@eileencodes

/cc@rafaelfranca@kaspth

Copy link
Member

@eileencodeseileencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but there's a test failing

https://travis-ci.org/rails/rails/jobs/434724993#L1708

@eileencodeseileencodes added this to the6.0.0 milestoneSep 28, 2018
@gmcgibbongmcgibbonforce-pushed thechange_migrations_paths_command_option_to_db branch from15a23b9 to4775d3dCompareSeptember 28, 2018 18:24
@gmcgibbon
Copy link
MemberAuthor

Sorry about that, its 🍏 now!

@eileencodeseileencodes merged commit7bc343b intorails:masterSep 28, 2018
@eileencodes
Copy link
Member

Thanks!

@gmcgibbongmcgibbon deleted the change_migrations_paths_command_option_to_db branchOctober 5, 2018 20:30
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull requestOct 15, 2018
…ors [ci skip]`migrations_paths` option was added to migration generator, withchangelog entry, inrails#33760.Also `migrations_paths` option was added to model generator, withchangelog entry, inrails#33994.Then `migrations_paths` was renamed to `database` and aliased as `db`inrails#34021, and was added new changelog entry.I think we should edit existed changelog entries instead adding newabout changing the name of the option from `migrations_paths` to `database`since Rails 6.0 hasn't been released yet, and since It might confusereaders of the changelog file in case if they've read changelog enty aboutadding `migrations_paths` option but haven't read the entry aboutchange the name of that option to `database`.@eileencodes,@gmcgibbon,@rafaelfranca Does it make sense?
y-yagi added a commit to y-yagi/rails that referenced this pull requestMar 20, 2019
suketa added a commit to suketa/rails_sandbox that referenced this pull requestJun 9, 2019
* [Add migrations_paths option to migration generator](rails/rails#33760)* [Add migrations_paths option to model generator](rails/rails#33994)* [Refactor migrations_path command option to database](rails/rails#34021)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@eileencodeseileencodeseileencodes left review comments

Assignees

@eileencodeseileencodes

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gmcgibbon@eileencodes

[8]ページ先頭

©2009-2025 Movatter.jp