irb>Rails.cache.increment("my_counter",1,expires_in:100)1irb>Rails.cache.data.ttl("my_counter")=>99# skip set expire when "my_counter" has ttlirb>Rails.cache.increment("my_counter",1,expires_in:200)2irb>Rails.cache.data.ttl("my_counter")=>98

rails-bot assignedkamipo

Jun 29, 2018

Copy link

rails-bot commentedJun 29, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from@kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues usingCode Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please seethe contribution instructions for more information.

Add :expires_in option support for RedisCacheStore increment/decremen…

9d5b02e

…t method.

huacnlee force-pushed theadd-expires-in-option-support-for-redis-cache-store-increment-method branch from72cb3c9 to9d5b02eCompare

June 29, 2018 07:53

rafaelfranca merged commit4883f73 intorails:master

Jun 29, 2018

huacnlee deleted the add-expires-in-option-support-for-redis-cache-store-increment-method branch

June 29, 2018 09:12

huacnlee mentioned this pull request

Jun 30, 2018

Fix Cache :redis_store increment/decrement ttl check and add more tests.#33264

Merged

kaspth added a commit that referenced this pull request

Jul 1, 2018

Refactor#33254.

969577d

Firstly, increment and decrement shouldn't care about the particulars ofkey expiry. They should only know that they have to pass that responsibilityon to somewhere else.Secondly, it moves the key normalization back inside the instrumentation likeit was originally. I think that matches the original design intention or atthe very least it lets users catch haywire key truncation.Thirdly, it moves the changelog entry to the top of the file, where new entriesgo. I couldn't understand what the entry was saying so I tried to rewrite it.