Oct 10, 2016 · May 10, 2016 · May 10, 2016 · May 10, 2016 · May 10, 2016 · May 21, 2016
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md
 *   Remove deprecated methods in `ActionController::Parameters`.

    *Rafael Mendonça França*

 *   Remove deprecated support to comparing a `ActionController::Parameters`
    with a `Hash`.

diff --git a/actionpack/lib/action_controller/metal/strong_parameters.rb b/actionpack/lib/action_controller/metal/strong_parameters.rb
      end
    end

    # Undefine `to_param` such that it gets caught in the `method_missing`
    # deprecation cycle below.
    undef_method :to_param

    def method_missing(method_sym, *args, &block)
      if @parameters.respond_to?(method_sym)
        message = <<-DEPRECATE.squish
          Method #{method_sym} is deprecated and will be removed in Rails 5.1,
          as `ActionController::Parameters` no longer inherits from
          hash. Using this deprecated behavior exposes potential security
          problems. If you continue to use this method you may be creating
          a security vulnerability in your app that can be exploited. Instead,
          consider using one of these documented methods which are not
          deprecated: http://api.rubyonrails.org/v#{ActionPack.version}/classes/ActionController/Parameters.html
        DEPRECATE
        ActiveSupport::Deprecation.warn(message)
        @parameters.public_send(method_sym, *args, &block)
      else
        super
      end
    end

    protected
      attr_reader :parameters

diff --git a/actionpack/test/controller/required_params_test.rb b/actionpack/test/controller/required_params_test.rb
    assert params.value?("cinco")
  end

  test "Deprecated methods are deprecated" do
    assert_deprecated do
      ActionController::Parameters.new(foo: "bar").merge!(bar: "foo")
    end
  end

  test "to_query is not supported" do
 assert_deprecated do
 assert_raises(NoMethodError) do
      ActionController::Parameters.new(foo: "bar").to_param
    end
  end
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1,7 @@
		* Remove deprecated methods in `ActionController::Parameters`.

		Rafael Mendonça França

		* Remove deprecated support to comparing a `ActionController::Parameters`
		with a `Hash`.

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -611,28 +611,8 @@ def init_with(coder) # :nodoc:
		end
		end

		# Undefine `to_param` such that it gets caught in the `method_missing`
		# deprecation cycle below.
		undef_method :to_param
Copy link Contributor kaspthOct 10, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Should we still undef this? Copy link MemberAuthor rafaelfrancaOct 10, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think so. The idea to undef this was to users not call`to_param` on parameters expecting the hash behavior and getting the`to_s` result. If we keep it defined it will silently break again and users will have the wrong behavior. Copy link Contributor kaspthOct 10, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. 👌

		def method_missing(method_sym, *args, &block)
		if @parameters.respond_to?(method_sym)
		message = <<-DEPRECATE.squish
		Method #{method_sym} is deprecated and will be removed in Rails 5.1,
		as `ActionController::Parameters` no longer inherits from
		hash. Using this deprecated behavior exposes potential security
		problems. If you continue to use this method you may be creating
		a security vulnerability in your app that can be exploited. Instead,
		consider using one of these documented methods which are not
		deprecated: http://api.rubyonrails.org/v#{ActionPack.version}/classes/ActionController/Parameters.html
		DEPRECATE
		ActiveSupport::Deprecation.warn(message)
		@parameters.public_send(method_sym, *args, &block)
		else
		super
		end
		end

		protected
		attr_reader :parameters

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -72,14 +72,8 @@ class ParametersRequireTest < ActiveSupport::TestCase
		assert params.value?("cinco")
		end

		test "Deprecated methods are deprecated" do
		assert_deprecated do
		ActionController::Parameters.new(foo: "bar").merge!(bar: "foo")
		end
		end

		test "to_query is not supported" do
		assert_deprecated do
		assert_raises(NoMethodError) do
		ActionController::Parameters.new(foo: "bar").to_param
		end
		end
Expand Down