- Notifications
You must be signed in to change notification settings - Fork22.1k
Remove ActionController::ModelNaming#18194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove ActionController::ModelNaming#18194
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The methods in these modules are not used anywhere. They used to beinvoked in polymorphic_routes.rb but their usage was removed ine821045.What is your opinion about removing these methods?They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (inActionView).Please tell me if you think that removing this module is a good idea and,in that case, if the PR is okay as it is, or you'd rather start by showinga deprecation message, and remove the module in Rails 5.1.
sgrif commentedDec 25, 2014
We need some form of deprecation warning. Also go spend time with your family, this shit can wait. 😁 |
arthurnn commentedDec 25, 2014
merry xmas!!! |
claudiob commentedDec 25, 2014
Merry 🎄 to you all! 🎅 |
guilleiguaran commentedDec 26, 2014
Sorry, this was never supposed to be public, I forgot to mark it as private when I added it in166dbaa I've looking on Google and Github to check if someone really is using one of the methods inside of AC::Naming and I'm pretty sure no one is doing it and since 5.0 is a major release I think is reasonable to remove this without deprecation. |
…l-namingRemove ActionController::ModelNaming
rafaelfranca commentedDec 29, 2014
👍 |
The methods in these modules are not used anywhere.
They used to be invoked in
polymorphic_routes.rbbut their last usage was removed ine821045.What is your opinion about removing these methods?
They do belong to the public API, but in reality their code hasalready been duplicated into
ActionView::ModelNaming.The ActionView module is still used (by
dom_idanddom_classto associate records with DOM elements).The ActionController module is not.
Please tell me if you think that removing this module is a good idea and if you feel like the PR is okay as it is, or whether some deprecation warning should be displayed.