Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove ActionController::ModelNaming#18194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@claudiob
Copy link
Member

The methods in these modules are not used anywhere.
They used to be invoked inpolymorphic_routes.rb but their last usage was removed ine821045.

What is your opinion about removing these methods?
They do belong to the public API, but in reality their code hasalready been duplicated intoActionView::ModelNaming.

The ActionView module is still used (bydom_id anddom_classto associate records with DOM elements).
The ActionController module is not.

Please tell me if you think that removing this module is a good idea and if you feel like the PR is okay as it is, or whether some deprecation warning should be displayed.

The methods in these modules are not used anywhere. They used to beinvoked in polymorphic_routes.rb but their usage was removed ine821045.What is your opinion about removing these methods?They do belong to the public API, but in reality their code has already been duplicated to ActionView::ModelNaming, since they are used by methods like `dom_id` and `dom_class` to associated records with DOM elements (inActionView).Please tell me if you think that removing this module is a good idea and,in that case, if the PR is okay as it is, or you'd rather start by showinga deprecation message, and remove the module in Rails 5.1.
@sgrif
Copy link
Contributor

We need some form of deprecation warning. Also go spend time with your family, this shit can wait. 😁

@arthurnn
Copy link
Member

merry xmas!!!

@claudiob
Copy link
MemberAuthor

Merry 🎄 to you all! 🎅

@guilleiguaran
Copy link
Member

Sorry, this was never supposed to be public, I forgot to mark it as private when I added it in166dbaa

I've looking on Google and Github to check if someone really is using one of the methods inside of AC::Naming and I'm pretty sure no one is doing it and since 5.0 is a major release I think is reasonable to remove this without deprecation.

guilleiguaran added a commit that referenced this pull requestDec 26, 2014
@guilleiguaranguilleiguaran merged commit122f55c intorails:masterDec 26, 2014
@claudiobclaudiob deleted the remove-action-controller-model-naming branchDecember 26, 2014 10:36
@rafaelfranca
Copy link
Member

👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@claudiob@sgrif@arthurnn@guilleiguaran@rafaelfranca

[8]ページ先頭

©2009-2025 Movatter.jp