Commit87b6e6a

committed

Use public_send in value_for_collection

Avoid exposing private methods in view's helpers.Fixes#33546

1 parentb9807eb commit87b6e6aCopy full SHA for 87b6e6a

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,13 @@`
	`1`	`+* Stop exposing public methods in view's helpers.`
	`2`	`+`
	`3`	+ For example, in methods like`options_from_collection_for_select`,
	`4`	`+ it was possible to call private methods from the objects used.`
	`5`	`+`
	`6`	`+ See[#33546](https://github.com/rails/rails/issues/33546) for details.`
	`7`	`+`
	`8`	`+[Ana María Martínez Gómez](https://github.com/Ana06)`
	`9`	`+`
	`10`	`+`
`1`	`11`	* Fix issue with`button_to`'s`to_form_params`
`2`	`12`
`3`	`13`	`button_to` was throwing exception when invoked with`params` hash that

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -802,7 +802,7 @@ def extract_values_from_collection(collection, value_method, selected)`
`802`	`802`	`end`
`803`	`803`
`804`	`804`	`defvalue_for_collection(item,value)`
`805`		`-value.respond_to?(:call) ?value.call(item) :item.send(value)`
	`805`	`+value.respond_to?(:call) ?value.call(item) :item.public_send(value)`
`806`	`806`	`end`
`807`	`807`
`808`	`808`	`defprompt_text(prompt)`

Comments

(0)