Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Handle crashed member in quorum queue status#15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
michaelklishin merged 1 commit intorabbitmq:mainfromcloudamqp:qq_status_noproc
Nov 24, 2025

Conversation

@gomoripeti
Copy link
Contributor

Proposed Changes

ra:key_metrics/1 can return a very small metrics map in case a member is dead and it terminated so early that it hasn't recorded any counters yet.

In this edge case thequorum_status command used to crash, although returning status of other members is still useful.

$ rabbitmq-queues quorum_status <queue>Status of quorum queue <queue> on node rabbit@<host> ...Error:{{:case_clause, %{state: :noproc, membership: :unknown, machine_version: 6}}, [{:rabbit_quorum_queue, :"-status/2-lc$^0/1-0-", 2, [file: ~c"src/rabbit_quorum_queue.erl", line: 1252]}, {:rabbit_quorum_queue, :"-status/2-lc$^0/1-0-", 2, [file: ~c"src/rabbit_quorum_queue.erl", line: 1311]}, {:rabbit_quorum_queue, :status, 2, []}]}

Types of Changes

What types of changes does your code introduce to this project?
Put anx in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put anx in the boxes that apply.
You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.

  • Mandatory: I (or my employer/client) have have signed the CA (seehttps://github.com/rabbitmq/cla)
  • I have read theCONTRIBUTING.md document
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation tohttps://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

`ra:key_metrics/1` can return a very small metrics map in case amember is dead and it terminated so early that it hasn't recorded anycounters yet.In this edge case the `quorum_status` command used to crash, althoughreturning status of other members is still useful.```$ rabbitmq-queues quorum_status <queue>Status of quorum queue <queue> on node rabbit@<host> ...Error:{{:case_clause, %{state: :noproc, membership: :unknown, machine_version: 6}}, [{:rabbit_quorum_queue, :"-status/2-lc$^0/1-0-", 2, [file: ~c"src/rabbit_quorum_queue.erl", line: 1252]}, {:rabbit_quorum_queue, :"-status/2-lc$^0/1-0-", 2, [file: ~c"src/rabbit_quorum_queue.erl", line: 1311]}, {:rabbit_quorum_queue, :status, 2, []}]}```
Copy link
Collaborator

@michaelklishinmichaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you.

@michaelklishinmichaelklishin merged commit0e38285 intorabbitmq:mainNov 24, 2025
574 of 577 checks passed
michaelklishin added a commit that referenced this pull requestNov 25, 2025
Handle crashed member in quorum queue status (backport#15003)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@michaelklishinmichaelklishinmichaelklishin approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gomoripeti@michaelklishin

[8]ページ先頭

©2009-2025 Movatter.jp