- Notifications
You must be signed in to change notification settings - Fork4k
Handle crashed member in quorum queue status#15003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+49 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
`ra:key_metrics/1` can return a very small metrics map in case amember is dead and it terminated so early that it hasn't recorded anycounters yet.In this edge case the `quorum_status` command used to crash, althoughreturning status of other members is still useful.```$ rabbitmq-queues quorum_status <queue>Status of quorum queue <queue> on node rabbit@<host> ...Error:{{:case_clause, %{state: :noproc, membership: :unknown, machine_version: 6}}, [{:rabbit_quorum_queue, :"-status/2-lc$^0/1-0-", 2, [file: ~c"src/rabbit_quorum_queue.erl", line: 1252]}, {:rabbit_quorum_queue, :"-status/2-lc$^0/1-0-", 2, [file: ~c"src/rabbit_quorum_queue.erl", line: 1311]}, {:rabbit_quorum_queue, :status, 2, []}]}```michaelklishin approved these changesNov 24, 2025
Collaborator
michaelklishin left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
0e38285 intorabbitmq:main 574 of 577 checks passed
Uh oh!
There was an error while loading.Please reload this page.
12 tasks
michaelklishin added a commit that referenced this pull requestNov 25, 2025
Handle crashed member in quorum queue status (backport#15003)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ra:key_metrics/1can return a very small metrics map in case a member is dead and it terminated so early that it hasn't recorded any counters yet.In this edge case the
quorum_statuscommand used to crash, although returning status of other members is still useful.Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments