- Notifications
You must be signed in to change notification settings - Fork443
capitalize the first character of component name#272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fahhadalsubaie commentedOct 16, 2022
Thank you for saving my time! |
| @@ -22,7 +22,7 @@ | |||
| "", | |||
| "type State = {}", | |||
| "", | |||
| "export default class ${1:${TM_FILENAME_BASE}} extends Component<Props, State> {", | |||
| "export default class ${1:${TM_FILENAME_BASE/(.*)/${1:/capitalize}/}} extends Component<Props, State> {", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You made a great change, but what would happen if I want to push another snippet? or if I will have another request for changes on the component's name?
I think we can optimize it.
I'm suggesting formatting the component name only in one place and reusing that place.
i.e, use theTM_FILENAME_BASE and capitalize it before using it on the generated.json.
Then you will do all your changes in one place and only once, instead of repeating the logic for every snippet.
what do you say?
Uh oh!
There was an error while loading.Please reload this page.
#271