Commit6245273

authored

fix GenericStack.pop() and modify toString()

1. Call list[size] should return null (if list[size-1] is the last element of the stack), this does not happen because the pop() method does not actually eliminate any element.2. When pop() is called, size should never be left with a negative value.

1 parent1fcbde2 commit6245273Copy full SHA for 6245273

File tree

1 file changed

+17

-3

lines changed

Exercise_19/Exercise_19_01
- GenericStack.java

1 file changed

+17

-3

lines changed

`‎Exercise_19/Exercise_19_01/GenericStack.java`

Lines changed: 17 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,12 @@ public void push(E o) {`
`22`	`22`
`23`	`23`	`/** Return and remove the top element from the stack */`
`24`	`24`	`publicEpop() {`
`25`		`-Eo =list[--size];`
	`25`	`+if (--size <0)`
	`26`	`+size =0;`
	`27`	`+Eo =list[size];`
	`28`	`+E[]new_list = (E[])newObject[list.length];`
	`29`	`+System.arraycopy(list,0,new_list,0,size);`
	`30`	`+list =new_list;`
`26`	`31`	`returno;`
`27`	`32`	`}`
`28`	`33`
`@@ -41,6 +46,15 @@ private void doubleList() {`
`41`	`46`
`42`	`47`	`@Override// Override the toString array in the Object class`
`43`	`48`	`publicStringtoString() {`
`44`		`-return"stack: " +list.toString();`
	`49`	`+Strings ="Stack: [";`
	`50`	`+if (isEmpty())`
	`51`	`+returns +"]";`
	`52`	`+for (inti =0;i <size;i++) {`
	`53`	`+if (i ==size-1)`
	`54`	`+s +=list[i].toString() +"]";`
	`55`	`+else`
	`56`	`+s +=list[i].toString() +", ";`
	`57`	`+}`
	`58`	`+returns;`
`45`	`59`	`}`
`46`		`-}`
	`60`	`+}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6245273

File tree

1 file changed

1 file changed

`‎Exercise_19/Exercise_19_01/GenericStack.java`

0 commit comments