Commitcdb7912

authored

Dispatch namespaced call (#29)

* fix dispatch for namespaced calls* add news entry

1 parenta0b4c86 commitcdb7912Copy full SHA for cdb7912

File tree

+15

-1

lines changed

+15

-1

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`#sloop (development version)`
`2`	`2`
	`3`	+*`s3_dispatch()` now works for namespaced function calls (#25,@mgirlich).
	`4`	`+`
`3`	`5`	`#sloop 1.0.1`
`4`	`6`
`5`	`7`	`* sloop has a website:http://sloop.r-lib.org/ !`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,13 @@ s3_dispatch <- function(call, env = parent.frame()) {`
`37`	`37`	`if (!is_call(call)) {`
`38`	`38`	stop("`call` must be a function call",call.=FALSE)
`39`	`39`	`}`
`40`		`-generic<- as.character(call[[1]])`
	`40`	`+`
	`41`	`+f<-call[[1]]`
	`42`	`+if (is_call(f)) {`
	`43`	`+n<- length(f)`
	`44`	`+f<-f[[n]]`
	`45`	`+ }`
	`46`	`+generic<- as.character(f)`
`41`	`47`	`x<- eval(call[[2]],env)`
`42`	`48`
`43`	`49`	`class<- c(s3_class(x),"default")`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,12 @@ test_that("includes internal generics", {`
`16`	`16`	`expect_equal(out$method[[3]],"length (internal)")`
`17`	`17`	`})`
`18`	`18`
	`19`	`+test_that("can handle namespaced function call", {`
	`20`	`+out<- s3_dispatch(base::length(1))`
	`21`	`+ expect_length(out$method,4)`
	`22`	`+ expect_equal(out$method[[4]],"length (internal)")`
	`23`	`+})`
	`24`	`+`
`19`	`25`	`test_that("includes group generics", {`
`20`	`26`	`out<- s3_dispatch(-Sys.Date())`
`21`	`27`	`expect_equal(out$method, c("-.Date","-.default","Ops.Date","Ops.default","- (internal)"))`

Comments

(0)