Commitc9a1420

committed

Fix issue with data frame of new dependencies

I.e.r-lib/pak#764Newly discovered dependencies might be in a data frame.This check was always buggy, but now it errors becauseR 4.5.x is more picky about using logical vectors aslogical scalars.

1 parentc3d7441 commitc9a1420Copy full SHA for c9a1420

File tree

1 file changed

-4

lines changed

R
- resolution.R

1 file changed

-4

lines changed

`‎R/resolution.R‎`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -393,10 +393,11 @@ res__set_result_df <- function(self, private, row_idx, value) {`
`393`	`393`	`res__set_result_list<-function(self,private,row_idx,value) {`
`394`	`394`	`# already done?`
`395`	`395`	`if (all(value$ref%in%self$result$ref))return()`
`396`		`-# direct version already on the TODO list?`
`397`		`-if (value$ref%in%private$state$ref&&`
`398`		`-!value$direct&&`
`399`		`-private$state$direct[match(value$ref,private$state$ref)])return()`
	`396`	`+if (is.data.frame(value)) {`
	`397`	`+# if a data frame, then some might be done`
	`398`	`+done<-value$ref%in%private$state$ref`
	`399`	`+value<-value[!done,drop=FALSE]`
	`400`	`+ }`
`400`	`401`	`self$result<- res_add_df_entries(self$result,value)`
`401`	`402`	`}`
`402`	`403`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc9a1420

File tree

1 file changed

1 file changed

`‎R/resolution.R‎`

0 commit comments