Commitc4db034

committed

Use source platform for non-native sysreqs lookup

If looking up sysreqs for another platform, and the platforms arenot explicitly specified, then set 'platforms' to source. Ideally wewould set it according to `config$sysreqs_platform`, but we don'tcurrently have a way of doing that. This simplification should notfail currently, and even if we'll have sysreqs on non-source platformsin the future, it should fail very rarely. Hopefully we can improve it.Helps with #781.

1 parentfcad6cb commitc4db034Copy full SHA for c4db034

File tree

1 file changed

+14

-0

lines changed

R
- sysreqs.R

1 file changed

+14

-0

lines changed

`‎R/sysreqs.R‎`

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,20 @@ sysreqs_install_plan <- function(refs, upgrade = TRUE, config = list()) {`
`138`	`138`	`on.exit(unlink(lib,recursive=TRUE),add=TRUE)`
`139`	`139`	`config$library<-lib`
`140`	`140`	`}`
	`141`	`+# If looking up sysreqs for another platform, and the platforms are`
	`142`	`+# not explicitly specified, then set 'platforms' to source. Ideally we`
	`143`	+# would set it according to `config$sysreqs_platform`, but we don't
	`144`	`+# currently have a way of doing that. This simplification should not`
	`145`	`+# fail currently, and even if we'll have sysreqs on non-source platforms`
	`146`	`+# in the future, it should fail very rarely. Hopefully we can improve it.`
	`147`	`+if (!"platforms"%in% names(config)) {`
	`148`	`+if (`
	`149`	`+ ("sysreqs_platform"%in% names(config))&&`
	`150`	`+config$sysreqs_platform!= default_sysreqs_platform()`
	`151`	`+ ) {`
	`152`	`+config$platforms<-"source"`
	`153`	`+ }`
	`154`	`+ }`
`141`	`155`	`config$sysreqs<-TRUE`
`142`	`156`	`config$sysreqs_lookup_system<-FALSE`
`143`	`157`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc4db034

File tree

1 file changed

1 file changed

`‎R/sysreqs.R‎`

0 commit comments