Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/herePublic

- Improve readme and add getting started vignette (#44, @sharlagelfand).#44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
krlmlr merged 13 commits intor-lib:masterfromsharlagelfand:improve-readme
Jan 31, 2020

Conversation

@sharlagelfand
Copy link
Contributor

Improve README by adding:

Also added a "Getting Started" vignette which contains most of the same information as the README, but also further details on using here (and why we want to) in an Rmd in a subdirectory.

I assume you'll want to re-render the README so that it doesn't contain the file path to my tidy dev day folder. I'm a little fuzzy on where things (especially the pkgdown docs) might be off since@krlmlr has been making changes to the package while i've been working on it, but happy to work through it.

Closes#42

@codecov-io
Copy link

codecov-io commentedJan 31, 2020
edited
Loading

Codecov Report

Merging#44 intomaster willnot change coverage.
The diff coverage is17.39%.

Impacted file tree graph

@@           Coverage Diff           @@##           master      #44   +/-   ##=======================================  Coverage   11.11%   11.11%           =======================================  Files           4        4             Lines          36       36           =======================================  Hits            4        4             Misses         32       32
Impacted FilesCoverage Δ
R/here.R0% <ø> (ø)⬆️
R/aaa.R0% <0%> (ø)⬆️
R/zzz.R16.66% <16.66%> (ø)⬆️
R/here-dr.R30% <30%> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update7abfd76...e8507b9. Read thecomment docs.

Copy link
Member

@krlmlrkrlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks much better, thanks!

Can you please rescale the image to 1400 pixels wide?

@sharlagelfand
Copy link
ContributorAuthor

thanks, fixed the illustration size + ref!

@krlmlrkrlmlr changed the titleImprove readme and add getting started vignette- Improve readme and add getting started vignette (#44, @sharlagelfand).Jan 31, 2020
@krlmlrkrlmlr merged commit29bfa2e intor-lib:masterJan 31, 2020
@krlmlr
Copy link
Member

Thanks! The docs are in much better shape now!

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 31, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@krlmlrkrlmlrkrlmlr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve README, add "Get Started" article

3 participants

@sharlagelfand@codecov-io@krlmlr

[8]ページ先頭

©2009-2025 Movatter.jp