- Notifications
You must be signed in to change notification settings - Fork47
- Improve readme and add getting started vignette (#44, @sharlagelfand).#44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedJan 31, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #44 +/- ##======================================= Coverage 11.11% 11.11% ======================================= Files 4 4 Lines 36 36 ======================================= Hits 4 4 Misses 32 32
Continue to review full report at Codecov.
|
krlmlr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks much better, thanks!
Can you please rescale the image to 1400 pixels wide?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-Authored-By: Kirill Müller <krlmlr@users.noreply.github.com>
…into improve-readme
sharlagelfand commentedJan 31, 2020
thanks, fixed the illustration size + ref! |
krlmlr commentedJan 31, 2020
Thanks! The docs are in much better shape now! |
Improve README by adding:
Also added a "Getting Started" vignette which contains most of the same information as the README, but also further details on using here (and why we want to) in an Rmd in a subdirectory.
I assume you'll want to re-render the README so that it doesn't contain the file path to my tidy dev day folder. I'm a little fuzzy on where things (especially the pkgdown docs) might be off since@krlmlr has been making changes to the package while i've been working on it, but happy to work through it.
Closes#42