Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/cliPublic

Fix issue with links using fs::path() (#683)#791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rundel wants to merge1 commit intor-lib:main
base:main
Choose a base branch
Loading
fromrundel:issue#683

Conversation

@rundel
Copy link
Contributor

This is a pass at addressing the issue referenced in#683 - my understanding of the problem is that the default cli theme is causing the fs_path object to first be rendered as a link and then there is a second pass by.href or.run that tries to wrap that in a new link and these don't get along.

My proposed solution is just a quick check at the beginning ofmake_link_href() andmake_link_run() for the presence of an existing link and if detected then usingansi_strip() to remove the existing link before generating the new link. This may be a bit crude, and might nuke other things it shouldn't.

There are probably edge cases that I have not considered but I tried testing all of the other link methods and they already had some kind of existing link detection I believe.

Addingfs to suggests seemed like the path of least resistance but if that is not desirable then it should be avoidable by more carefully constructing the tests.

The major issue seems to be resolved but I am not 100% on if the output is exactly as desired in all test cases but everything looked reasonable to me based on the snapshots.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rundel

[8]ページ先頭

©2009-2025 Movatter.jp