Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
/trayPublic
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Log4j update (2.1)#896

Merged
tresf merged 5 commits into2.1from2.1-logupd
Dec 17, 2021
Merged

Log4j update (2.1)#896

tresf merged 5 commits into2.1from2.1-logupd
Dec 17, 2021

Conversation

akberenz
Copy link
Member

@akberenzakberenz commentedDec 15, 2021
edited by tresf
Loading

Edit: Related#893#895

@tresf
Copy link
Contributor

tresf commentedDec 15, 2021
edited
Loading

@bberenz for some reason the Log Dialog is empty and the log files aren't being created/appended (e.g. those normally found in%APPDATA%\qz). Any clue as to why?

@akberenz
Copy link
MemberAuthor

They appear to be working fine on my end. Are you getting any errors in the console?

@tresf
Copy link
Contributor

They appear to be working fine on my end. Are you getting any errors in the console?

Hadn't tried interactively (and the ones we'd normally use are missing, so a bit of a catch-22)

@akberenz
Copy link
MemberAuthor

Oh I suppose I am running from intellij, I can try running from installer when I have some time available later today.

@tresf
Copy link
Contributor

Oh I suppose I am running from intellij, I can try running from installer when I have some time available later today.

Oh that's even stranger. I wonder why it would it work in IDE but not installed.... that's bazaar. I can confirm that the Log Dialog and files are working just fine from IDE. Does this suggest that the config file isn't being read for some reason?

@tresf
Copy link
Contributor

Oh I suppose I am running from intellij, I can try running from installer when I have some time available later today.

So the interactive console is working when I start QZ Tray manually, but the Log Dialog is still empty. No glaring issues in the interactive logs suggesting why.

So, I'm still perplexed by the difference in behavior between IDE and installed version for the 2.1 branch.

@tresf
Copy link
Contributor

Seems to be a jigsaw-related issue, log4j uses two different techniques for printing stacktraces and they're incompatible with older and newer JREs respectively. I don't know how to fix this, but people are talking about a "multi-release" jar, which sounds like a can of worms....https://stackoverflow.com/questions/53049346/is-log4j2-compatible-with-java-11

We do add some jigsaw flags at runtime, so if we know how to toggle between the dependencies, I think we can make this work to allow running with either Java 8 or Java 11 (as well as 17, etc).

@lite1979
Copy link
Contributor

Tested on Metal with Windows 10, Ubuntu 20.04, and MacOS Big Sur (Intel). Logs look good!

@tresftresf merged commitf28baee into2.1Dec 17, 2021
@tresftresf deleted the 2.1-logupd branchDecember 17, 2021 01:33
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@akberenz@tresf@lite1979

[8]ページ先頭

©2009-2025 Movatter.jp