Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change it so the categories endpoint is consistent by removing slugify#276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ACR1209
Copy link
Contributor

Description

This change removes the use of theslugify function from the categories endpoint when fetching the json data, as this is inconsistent with the rest of the endpoints, which do not do this step.

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes#275

Additional Context

This was failing due to inconsistent rules regarding if the passed language is slugged or not. On snippets they're not slugged, thus simply removing this fixes the consistency problem.

Meaning, the current syntax to denote a sub-language (eg.javascript--react) was getting slugged like it was it's own language (eg.javascript-react).

@ACR1209
Copy link
ContributorAuthor

The CI checks are failing, but I think it's trying to call an nonexistent scriptcspell from the project root, or am I mistaken? 😟

@ACR1209ACR1209force-pushed thefix/fix-categories-failing-to-load-for-framework branch from3d7fe5c to4c3efeaCompareJune 1, 2025 03:25
@technoph1letechnoph1le merged commit7c1e59f intoquicksnip-dev:mainJun 2, 2025
0 of 2 checks passed
@technoph1le
Copy link
Collaborator

Hi, there. Thanks for the fix. It's interesting why cspell threw an error. I will look into that.

ACR1209 reacted with laugh emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Mathys-GasnierMathys-GasnierAwaiting requested review from Mathys-Gasnier

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] - API request is failing for frameworks

2 participants

@ACR1209@technoph1le

[8]ページ先頭

©2009-2025 Movatter.jp