- Notifications
You must be signed in to change notification settings - Fork128
Use shadcn components#154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
netlifybot commentedJan 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forquicksnip ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
psychlone77 commentedJan 3, 2025
Instead of ignoring the |
mayur1377 commentedJan 3, 2025
Mathys-Gasnier commentedJan 3, 2025
I'm too thinking we should ignore the components from shad-cn, it will just be a pain to reformat them each time. |
psychlone77 commentedJan 3, 2025
We will only have to fix the linting errors once when someone adds a new 'shadcn component' to the project. Since 'shadcn' components is still someone else' s code and we are technically just copy pasting the components into the project, we should still make sure that code follows the project's eslint rules. Running |
mayur1377 commentedJan 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
any updates of still using shadcn? |
Mathys-Gasnier commentedJan 8, 2025
Fix conflicts and errors of your PR before we review again |
jjcantu commentedJan 10, 2025
@Mathys-Gasnier I think we should probably open up another MR for this. It is blocking a lot of other developers from contributing. |

Description
add shad-cn components
Type of Change
note : there are some linting errors from the already pre-built shad-cn components , would recommend to disable folder that folder