Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Vendor efficientnet-pytorch#1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
qubvel merged 4 commits intoqubvel-org:mainfromadamjstewart:deps/efficientnet
Jan 16, 2025

Conversation

adamjstewart
Copy link
Collaborator

Supersedes#1018

EfficientNet-PyTorch doesn't have wheels on PyPI, and is no longer maintained. Let's vendor it and maintain it ourselves. This will make SMP easier to install.

This PR doesn't deprecate the non-timm EfficientNet implementation, but we can also do that if we want to. Let's wait until we have download statistics.

Will do the same thing with pretrainedmodels once this is merged.

@codecovCodecov
Copy link

codecovbot commentedJan 15, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is71.47766% with83 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
...mentation_models_pytorch/encoders/_efficientnet.py71.37%83 Missing⚠️
Files with missing linesCoverage Δ
...gmentation_models_pytorch/encoders/efficientnet.py94.33% <100.00%> (-0.11%)⬇️
...mentation_models_pytorch/encoders/_efficientnet.py71.37% <71.37%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubvel
Copy link
Collaborator

qubvel commentedJan 15, 2025•
edited
Loading

Thanks for moving it and removing dependency! What do you think re removing unnecessary code? I mean not all functions/methods are required, such asfrom_pretrained

adamjstewart reacted with thumbs up emoji

Copy link
Collaborator

@qubvelqubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Copy link
Collaborator

@qubvelqubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, a few things to remove and we can merge it

@qubvelqubvel merged commitce65165 intoqubvel-org:mainJan 16, 2025
16 of 17 checks passed
@qubvel
Copy link
Collaborator

Thanks!

@adamjstewartadamjstewart deleted the deps/efficientnet branchJanuary 16, 2025 11:41
@adamjstewart
Copy link
CollaboratorAuthor

pretrainedmodels is up next. This one is a bit more complicated because we have multiple models. Should we have asegmentation_models_pytorch/encoders/_pretrainedmodels/ directory containing each model, or multiplesegmentation_models_pytorch/encoders/_foo.py files for each model?

@qubvel
Copy link
Collaborator

I prefersegmentation_models_pytorch/encoders/_foo.py, but feel free to choose the one you think is better.

adamjstewart reacted with thumbs up emoji

@qubvelqubvel mentioned this pull requestApr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@qubvelqubvelqubvel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@adamjstewart@qubvel
[8]ページ先頭
©2009-2025 Movatter.jp