Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dispose of the FacadeClassLoader at the end of every test plan so surefire reruns are tolerated#51298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
holly-cummins wants to merge1 commit intoquarkusio:main
base:main
Choose a base branch
Loading
fromholly-cummins:tolerate-surefire-354

Conversation

@holly-cummins
Copy link
Contributor

@holly-cumminsholly-cummins commentedNov 28, 2025
edited
Loading

Fixes#51269.

The current problem in CI (and for users) was caused by#50092, which bumped surefire from 3.5.3 to 3.5.4. We didn't catch it because (a) thetests for maven reruns wasn't merged and (b) they didn't lock the version of surefire to the one used by the rest of the build, so they wouldn't have caught the regression. I've confirmed that when I do add the version, the tests start failing, and this PR gets them passing again.

The root cause was thatapache/maven-surefire#863 changed how surefire handledLauncherSessions so that one session was created for the whole process, rather than one for each test run. That meant that on runs after the first one, the rerun tests would still be loaded with the 'old' classloader and attached to the previous app. I worried this would be hard to fix the hooking the end of the test execution allows us to close everything at the right point.

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

I force pushed a reformat so that CI can run tonight.

holly-cummins reacted with heart emoji

This is needed because the session launcher might stay open for several test runs if surefire reruns tests.
@quarkus-bot
Copy link

quarkus-botbot commentedNov 28, 2025
edited by github-actionsbot
Loading

Status for workflowQuarkus CI

This is the status report for runningQuarkus CI on commit6bf4f0a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult theDevelocity build scans.


Flaky tests -Develocity

⚙️ JVM Integration Tests - JDK 21 Semeru

📦 integration-tests/virtual-threads/grpc-virtual-threads

io.quarkus.grpc.example.streaming.VirtualThreadTest.testGrpcClient -History

  • 1 expectation failed. Expected status code <200> but was <500>. -java.lang.AssertionError
java.lang.AssertionError: 1 expectation failed.Expected status code <200> but was <500>.at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@geoandgeoandAwaiting requested review from geoand

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-running failing test fails with classloader errors

2 participants

@holly-cummins@gsmet

[8]ページ先頭

©2009-2025 Movatter.jp