Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix typos across multiple modules and rename ReponseInfoTest#51260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
QuarkOS wants to merge1 commit intoquarkusio:main
base:main
Choose a base branch
Loading
fromQuarkOS:chore/fix-typos-logs

Conversation

@QuarkOS
Copy link

Summary

While reviewing the codebase, I identified and corrected spelling errors across several extensions (Kubernetes, Redis, Qute, OIDC) and independent projects

Changes

  • Class Rename: RenamedReponseInfoTest toResponseInfoTest inindependent-projects/resteasy-reactive to fix a typo in the class name
  • Log Messages: Fixed "succesfully" -> "successfully" inOidcClientRegistrationImpl andRegisteredClientImpl to improve log searchability
  • Javadocs & Comments: Corrected various typos ("teh", "accross", "seperated") inImageBuilder,WebSocket, etc
  • Resources: Fixed typos in Grafana dashboard JSON files

Verification

  • these changes are primarily documentation, log messages, and a test class rename
  • verified that the file rename was correctly handled via Git (git status showedrenamed:)

Checklist

  • I have read thecontributing guide
  • I have analyzed the best way to implement the fix
  • I have tested the changes (verified file status and spelling)

@quarkus-botquarkus-botbot added area/core area/devtoolsIssues/PR related to maven, gradle, platform and cli tooling/plugins area/graphql area/kubernetes area/oidc area/openapi area/platformIssues related to definition and interaction with Quarkus Platform area/quteThe template engine area/redis area/smallrye area/testing labelsNov 26, 2025
@QuarkOSQuarkOS changed the titlechore: fix typos across multiple modules and rename ReponseInfoTestFix typos across multiple modules and rename ReponseInfoTestNov 26, 2025
Copy link
Member

@gsmetgsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks. The typo fixes looks good but I think we should revert the changes inStartupLogCompressor and squash.

Can you take care of it?

Comment on lines 72 to 74
if (sl !=null) {
sl.close();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think this is needed as it's protected by thethread == null test.

Same for the other fixes in this class.

geoand and QuarkOS reacted with thumbs up emoji
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done. Ive reverted the changes toStartupLogCompressor.java and squashed the commits

Corrected spelling errors in Javadocs, logs, and comments across OIDC, Kubernetes, and Qute extensions. Renamed ReponseInfoTest to ResponseInfoTest to fix class name typo.Signed-off-by: Quark <quackingquark@gmail.com>
@quarkus-bot
Copy link

Status for workflowQuarkus Documentation CI

This is the status report for runningQuarkus Documentation CI on commit914023e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions
Copy link

🎊 PR Preview3f428b9 has been successfully built and deployed tohttps://quarkus-pr-main-51260-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-botbot commentedNov 27, 2025
edited by github-actionsbot
Loading

Status for workflowQuarkus CI

This is the status report for runningQuarkus CI on commit914023e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult theDevelocity build scans.


Flaky tests -Develocity

⚙️ JVM Tests - JDK 25

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.CompletionStageTest.testSourcePost -History

  • 1 expectation failed. Expected status code <200> but was <500>. -java.lang.AssertionError
java.lang.AssertionError: 1 expectation failed.Expected status code <200> but was <500>.at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable -History

  • Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> -java.lang.AssertionError
java.lang.AssertionError: Expecting the metric Compensated callback was calledExpected: a value equal to or greater than <1>     but: <0> was less than <1>at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gsmetgsmetgsmet approved these changes

Assignees

No one assigned

Labels

area/corearea/devtoolsIssues/PR related to maven, gradle, platform and cli tooling/pluginsarea/graphqlarea/kubernetesarea/oidcarea/openapiarea/platformIssues related to definition and interaction with Quarkus Platformarea/quteThe template enginearea/redisarea/smallryearea/testingtriage/flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuarkOS@gsmet

[8]ページ先頭

©2009-2025 Movatter.jp