Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Test all notebooks vs stable Cirq after the release#7561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mhucka merged 7 commits intoquantumlib:mainfrommhucka:mh-7556
Aug 12, 2025

Conversation

@mhucka
Copy link
Contributor

@mhuckamhucka commentedAug 6, 2025•
edited by pavoljuhas
Loading

Make all notebook tests use stable cirq after the 1.6.0 release.

Ref:https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle

Fixes#7556

Update `NOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES` to reflect changesin the contents of the `docs/simulate` directory.
@mhuckamhucka marked this pull request as ready for reviewAugust 6, 2025 14:33
@mhuckamhucka requested review froma team andvtomole ascode ownersAugust 6, 2025 14:33
@mhuckamhucka requested a review fromviathorAugust 6, 2025 14:33
@github-actionsgithub-actionsbot added the Size: XS<10 lines changed labelAug 6, 2025
@codecov
Copy link

codecovbot commentedAug 6, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.49%. Comparing base (1be4d9a) to head (e3b3344).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #7561      +/-   ##==========================================- Coverage   97.49%   97.49%   -0.01%==========================================  Files        1101     1101                Lines       99421    99421              ==========================================- Hits        96934    96933       -1- Misses       2487     2488       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhuckamhucka added priority/before-1.6.1Finish before the Cirq 1.6.1 release area/docs labelsAug 7, 2025
@review-notebook-app
Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered byReviewNB

@github-actionsgithub-actionsbot added size: M50< lines changed <250 and removed Size: XS<10 lines changed labelsAug 12, 2025
@pavoljuhaspavoljuhas changed the titleFix #7556: update isolated_notebook_test.pyTest all notebooks vs stable Cirq after the 1.6.0 releaseAug 12, 2025
@pavoljuhaspavoljuhas changed the titleTest all notebooks vs stable Cirq after the 1.6.0 releaseTest all notebooks vs stable Cirq after the releaseAug 12, 2025
@pavoljuhas
Copy link
Collaborator

The point ofhttps://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycle is to makeNOTEBOOKS_DEPENDING_ON_UNRELEASED_FEATURES empty and to change any pip-install instructions in the affected notebooks to install stable cirq.

Copy link
Collaborator

@pavoljuhaspavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM after pushingd432d4b...58a8fd7. Please check if this looks OK on your side.

@mhuckamhucka added this pull request to themerge queueAug 12, 2025
Merged via the queue intoquantumlib:main with commitb5ca970Aug 12, 2025
35 checks passed
@mhuckamhucka deleted the mh-7556 branchAugust 12, 2025 02:12
pavoljuhas added a commit that referenced this pull requestAug 14, 2025
Make all notebook tests use stable cirq after the 1.6.0 release.Ref:https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycleFixes#7556---------Co-authored-by: Pavol Juhas <juhas@google.com>
ddddddanni pushed a commit to ddddddanni/Cirq that referenced this pull requestAug 25, 2025
Make all notebook tests use stable cirq after the 1.6.0 release.Ref:https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycleFixesquantumlib#7556---------Co-authored-by: Pavol Juhas <juhas@google.com>
ddddddanni pushed a commit to ddddddanni/Cirq that referenced this pull requestSep 1, 2025
Make all notebook tests use stable cirq after the 1.6.0 release.Ref:https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md#lifecycleFixesquantumlib#7556---------Co-authored-by: Pavol Juhas <juhas@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pavoljuhaspavoljuhaspavoljuhas approved these changes

@vtomolevtomoleAwaiting requested review from vtomolevtomole is a code owner

@viathorviathorAwaiting requested review from viathorviathor is a code owner automatically assigned from quantumlib/cirq-maintainers

@dstrain115dstrain115Awaiting requested review from dstrain115

Assignees

No one assigned

Labels

area/docspriority/before-1.6.1Finish before the Cirq 1.6.1 releasesize: M50< lines changed <250

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test all notebooks vs stable Cirq after the 1.6.0 release

2 participants

@mhucka@pavoljuhas
[8]ページ先頭
©2009-2025 Movatter.jp