Hi - thanks for the patches. Can you rebase these onto current git master so all the double-counted commits go away?

Hmmm is this really needed? I have two batteries and just use two battery widgets

Hmmm is this really needed? I have two batteries and just use two battery widgets

I would really like this to be merged please.

This was a request of mine months ago, i have many thinkpads with two batteries, yes i have been using two widgets for that but it makes space problems on the bar and it’s a bit confusing with two to know the exact eta for time left on battery, with this, i can get a single widget that shows me the time left from both batteries and have one extra space for another widget that i could really use.

• extra space for another widget
• Proper eta of time left on battery
• A more tidy bar

Thanks !

Hi - thanks for the patches. Can you rebase these onto current git master so all the double-counted commits go away?

Hi Tych0
Sorry for the late reply. Sorry again, but it's my first time contributing into a project and i don't known to much about git. I use it only for get my configuration files and password-store saved in a "safe" place, you know...git clone, push and pull.
I'm reading a git book trying to get a deeper knowledge about and i'm not sure if i did it's right or not, so excuse me if i make mistakes.
I run these commandsgit rebase
git checkout master
git rebase
git rebase multiple_batteries
multiple_batteries is my dev branch
Sorry but i don't know if it's what you expect to be done or if i need to run any other command.

Thanks and kind regards

Right now your branch has multiple commits that already exist on master. I don't know how you got into this state, but I think you can fix it via the following:

git checkout multiple_batteriesgit checkout -b multiple_batteries-pendinggit checkout multiple_batteriesgit reset --hard origin/mastergit cherry-pick <the sha of your git patch from multiple_batteries>

What we need to land this is a clean git history on the branch.

Can you also address@jwijenbergh's comment? In particular, can this be addressed with adding some margin tuning vs. having this for loop over batteries?

Hi tych0
I run the git commands as you suggested and i hope that everything is fixed now.
The widget add the option to show the overall info in one place. I changed the default value because is the way that it works in others projects: kde, gnome, zsh... but If you want 2 widgets as@jwijenbergh you can get them or if you want only one as@Sniki and me you can get it too.
In this image I have two widgets, in the left side showing the overall status and the right one showing the first battery, but you can configure it as you wish.

widget.Battery(battery=-1),powerline('color2', 'color3'),widget.Battery(battery=0),

I loop over the batteries but i only get the info of the selected battery. In the LinuxBattery class

for bat in bats:    if int(batnum) < 0 or self.battery == bat:

In the FreeBSD class:

for bat in range(numbat):    if bat == int(self.battery) or int(self.battery) < 0:

I have some comments on this too and will post them when I get a chance.

Be patient. I have to install a linux distribution in my laptop and i have to be sure that when i come back to freebsd i have all my conf files...;)

Hi All,
After reinstall the laptop I have changed the percentage calculation and the result is the same as in gnome. So if i'm doing wrong the gnome guys too. I'm continue running the code waiting some difference in the numbers so i'll commit the modification tomorrow. Meanwhile i'm enjoy with the debian experience.

Did you mean to close this?

Hi,
I thought that i was resolving your comments....sorry but works with git and all this stuff is very difficult to me.

Thanks and kind regards.

This PR is stale because it has been open 90 days with no activity. Remove thestatus: stale label or comment, or this will be closed in 30 days.

What is left for this PR to be ready for merge ?
As long as the accuracy of battery reporting is somewhat close, it should be fine.

CC@fjpavon

What is left for this PR to be ready for merge ? As long as the accuracy of battery reporting is somewhat close, it should be fine.

CC@fjpavon

Sorry i was focused in other stuff and i forgot that it was not finisthed.
During the weekend i was working trying to fix an error in the test_battery and i disconvered that it's not working on FreeBSD...but it's resolved, now the problem is the rufus-format .
I think that the os check in the tests can be the next issue to resolve.