Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Implement move_to_{top,bottom} in Wayland#4629

Open
QBobWatson wants to merge2 commits intoqtile:master
base:master
Choose a base branch
Loading
fromQBobWatson:wayland-move-top-bottom

Conversation

QBobWatson
Copy link
Contributor

This addsmove_to_top() andmove_to_bottom() to Wayland windows. Thebring_to_front() command had already been implemented, and these do essentially the same thing. (Before there was no command to lower a Wayland window.)

@elParaguayo
Copy link
Member

Thanks for all the pull requests!

I'm not getting involved in these, though, as they're Wayland focused so I'll leave it to the experts.

@m-col
Copy link
Member

Thanks for the PR.@elParaguayo what are the differences in semantics betweenbring_to_front andmove_to_top? Their implementations differ in the X backend.

@elParaguayo
Copy link
Member

The definitions inbase.window have the same signature as these methods. However, in X11 we have an additional, optional keyword argumentforce. This is is used where a window is tagged askept_above/below. Forcing disables that tag and then moves the window.

Can Wayland implementkeep_above/below too?

@QBobWatson
Copy link
ContributorAuthor

Can Wayland implement keep_above/below too?

The analogous functionality is provided by the layer shell. This is implemented in the sense that clients can request to be placed on different layers using the layer shell protocol, but currently qtile can't place windows on a specified layer. I'd have to look through the protocol to figure out how that's supposed to work. In any case, it's beyond the scope of this PR.

@elParaguayo
Copy link
Member

That's fine. However, given the x11 backend allows theforce argument to themove_to_top/bottom methods, we should allow them here so there's no config breakages between backends. We can then add the other functionality later.

@m-col@jwijenbergh any concerns with that approach?

@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove thestatus: stale label or comment, or this will be closed in 30 days.

@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove thestatus: stale label or comment, or this will be closed in 30 days.

@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove thestatus: stale label or comment, or this will be closed in 30 days.

@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove thestatus: stale label or comment, or this will be closed in 30 days.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@QBobWatson@elParaguayo@m-col

[8]ページ先頭

©2009-2025 Movatter.jp