- Notifications
You must be signed in to change notification settings - Fork46
Issue #247 - Replaceexecute withbackend.run() inqiskit-qec#381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
grace-harper merged 9 commits intoqiskit-community:mainfromsim-eng-ii:replace-execute-with-backend.runSep 19, 2023
Merged
Issue #247 - Replaceexecute withbackend.run() inqiskit-qec#381
grace-harper merged 9 commits intoqiskit-community:mainfromsim-eng-ii:replace-execute-with-backend.runSep 19, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Author
sim-eng-ii commentedAug 17, 2023
@grace-harper I have fixed#247 and it is ready for review |
execute withbackend.run() inqiskit-qecexecute withbackend.run() inqiskit-qecexecute withbackend.run() inqiskit-qecexecute withbackend.run() inqiskit-qecAuthor
sim-eng-ii commentedAug 25, 2023
Hello@grace-harper , I will look into the issues. Thank you |
Author
sim-eng-ii commentedAug 25, 2023
Hello@grace-harper the test errors are related to a bug I identified and described in issue#380. I do not think is related to the work I did on issue#247. Regarding the lint/style check. I will fix those. Thank you. |
grace-harper approved these changesSep 19, 2023
Collaborator
grace-harper left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
grace-harper pushed a commit that referenced this pull requestSep 19, 2023
Fix a small bug (#384)Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com>Update README.md (#377)Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com>Issue#247 - Replace `execute` with `backend.run()` in `qiskit-qec` (#381)* replace `execute` with `backend.run()` in `test_repetitionmatcher.py`* replace `execute` with `backend.run()` in `test_circuitmatcher.py`* replace `execute` with `backend.run()` in `test_heavy_hex_decoder.py`* replace `execute` with `backend.run()` in `faultsampler.py`* replace `execute` with `backend.run()` in `faultenumerator.py`* formatting* re-format test_repetitionmatcher.py---------Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com>scrap
grace-harper added a commit that referenced this pull requestOct 2, 2023
…381)* replace `execute` with `backend.run()` in `test_repetitionmatcher.py`* replace `execute` with `backend.run()` in `test_circuitmatcher.py`* replace `execute` with `backend.run()` in `test_heavy_hex_decoder.py`* replace `execute` with `backend.run()` in `faultsampler.py`* replace `execute` with `backend.run()` in `faultenumerator.py`* formatting* re-format test_repetitionmatcher.py---------Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary:
This pull request aims to resolve issue#247 by replacing the outdated
executefunction with the more up-to-datebackend.runmethod in theqiskit-qeccodebase.Details and comments:
executewithbackend.runfor simulating the quantum circuit.Additional Notes:
The following files have been modified:
test/matching/test_circuitmatcher.pytest/matching/test_repetitionmatcher.pysrc/qiskit_qec/analysis/faultsampler.pysrc/qiskit_qec/analysis/faultenumerator.pytest/heavy_hex_codes/test_heavy_hex_decoder.py