Commitaff2c35

committed

Revert "Alter read_only+default behaviour (encode#5886)"

This reverts commitc2b24f8.

1 parent9b7db8d commitaff2c35Copy full SHA for aff2c35

File tree

-10

lines changed

-10

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,7 @@ A default class that can be used to *only set a default argument during create o`
`189`	`189`	`It takes a single argument, which is the default value or callable that should be used during create operations.`
`190`	`190`
`191`	`191`	`created_at = serializers.DateTimeField(`
	`192`	`+ read_only=True,`
`192`	`193`	`default=serializers.CreateOnlyDefault(timezone.now)`
`193`	`194`	`)`
`194`	`195`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,8 @@ def fields(self):`
`367`	`367`	`@cached_property`
`368`	`368`	`def_writable_fields(self):`
`369`	`369`	`return [`
`370`		`-fieldforfieldinself.fields.values()ifnotfield.read_only`
	`370`	`+fieldforfieldinself.fields.values()`
	`371`	`+if (notfield.read_only)or (field.defaultisnotempty)`
`371`	`372`	`]`
`372`	`373`
`373`	`374`	`@cached_property`

Lines changed: 1 addition & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -217,17 +217,10 @@ def example_callable(self):`
`217`	`217`	`classTestReadOnly:`
`218`	`218`	`defsetup(self):`
`219`	`219`	`classTestSerializer(serializers.Serializer):`
`220`		`-read_only=serializers.ReadOnlyField(default="789")`
	`220`	`+read_only=serializers.ReadOnlyField()`
`221`	`221`	`writable=serializers.IntegerField()`
`222`	`222`	`self.Serializer=TestSerializer`
`223`	`223`
`224`		`-deftest_writable_fields(self):`
`225`		`-"""`
`226`		`- Read-only fields should not be writable, even with default ()`
`227`		`- """`
`228`		`-serializer=self.Serializer()`
`229`		`-assertlen(serializer._writable_fields)==1`
`230`		`-`
`231`	`224`	`deftest_validate_read_only(self):`
`232`	`225`	`"""`
`233`	`226`	`Read-only serializers.should not be included in validation.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -509,7 +509,7 @@ class ExampleSerializer(serializers.Serializer):`
`509`	`509`	`classTestDefaultInclusions:`
`510`	`510`	`defsetup(self):`
`511`	`511`	`classExampleSerializer(serializers.Serializer):`
`512`		`-char=serializers.CharField(default='abc')`
	`512`	`+char=serializers.CharField(read_only=True,default='abc')`
`513`	`513`	`integer=serializers.IntegerField()`
`514`	`514`	`self.Serializer=ExampleSerializer`
`515`	`515`

Comments

(0)