- Notifications
You must be signed in to change notification settings - Fork314
[debug][dtensor] hosting commdebugmode browser's visualizer PyTorch#1699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
sinhaanshul wants to merge3 commits intopytorch:siteChoose a base branch
base:site
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
👷 Deploy Preview forpytorch-dot-org-preview processing.
|
| </div> | ||
| <div id="tree-container"></div> | ||
| <script src="https://cdn.jsdelivr.net/gh/pytorch/pytorch@main/torch/distributed/_tensor/debug/comm_mode_broswer_visual.js"></script> |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What's wrong with referencing github script directly?
Suggested change
| <scriptsrc="https://cdn.jsdelivr.net/gh/pytorch/pytorch@main/torch/distributed/_tensor/debug/comm_mode_broswer_visual.js"></script> | |
| <scriptsrc="https://raw.githubusercontent.com/pytorch/pytorch/main/torch/distributed/_tensor/debug/comm_mode_broswer_visual.js"></script> |
Contributor
wanchaol commentedAug 2, 2024
Maybe we can start with a private html (with |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of CommDebugMode's features is that it allows users to create a json file using the debugger's output and create a tree structure of the results in a browser visualizer. I would like to host this html file on pytorch so that users don't have to constantly open the html file manually every single time they want to use it.