- Notifications
You must be signed in to change notification settings - Fork26.3k
Fix pow precision#25476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Fix pow precision#25476
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
VitalyFedyunin approved these changesAug 30, 2019
ContributorAuthor
pbelevich commentedAug 30, 2019
@pytorchbot rebase this please |
Contributor
facebook-github-bot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diffon Phabricator.
zdevito pushed a commit to zdevito/ATen that referenced this pull requestSep 1, 2019
Summary:Found in gpytorch:```test_computes_cubic_kernel (test.kernels.test_polynomial_kernel.TestPolynomialKernel) ... FAIL======================================================================FAIL: test_computes_cubic_kernel (test.kernels.test_polynomial_kernel.TestPolynomialKernel)----------------------------------------------------------------------Traceback (most recent call last): File "/mnt/xarfuse/uid-30041/0efc4638-seed-sandcastle-2ddc31a66f82cDbd-ns-4026533029/test/kernels/test_polynomial_kernel.py", line 70, in test_computes_cubic_kernel self.assertLess(torch.norm(res - actual), 1e-5)AssertionError: tensor(1.0790e-05, grad_fn=<NormBackward0>) not less than 1e-05```Pull Requestresolved:pytorch/pytorch#25476Differential Revision: D17147518Pulled By: pbelevichfbshipit-source-id: 60b619f5166d2bfaed7aa4803672e6be17d32b76
Contributor
facebook-github-bot commentedSep 1, 2019
@pbelevich merged this pull request in6a45851. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in gpytorch: