- Notifications
You must be signed in to change notification settings - Fork26.3k
Fixed nondeterministic RG for ORT RNN tests#25205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
neginraoof commentedAug 27, 2019
@pytorchbot rebase this please |
…pytorch into neraoof/ORT-RNNTests
neginraoof commentedAug 29, 2019
cc@dzhulgakov for review |
neginraoof commentedAug 29, 2019
@pytorchbot rebase this please |
dzhulgakov commentedAug 30, 2019
It's up to you folks, but 10% difference (i.e. 0.1 rtols) sounds like a lot |
neginraoof commentedSep 3, 2019
@dzhulgakov Changing tolerance is not necessary actually. I changed that back. RG is deterministic now so tests should not be flaky anymore. |
neginraoof commentedSep 4, 2019
@dzhulgakov@bddppq Can we merge this small PR? CI failures that will be prevented. |
lara-hdr commentedSep 6, 2019
@houseroad can we please merge this? |
facebook-github-bot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diffon Phabricator.
houseroad left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, will merge it soon.
facebook-github-bot commentedSep 7, 2019
@houseroad merged this pull request in5d7fff5. |
Uh oh!
There was an error while loading.Please reload this page.
Relaxing tolerance for ORT RNN tests