NotificationsYou must be signed in to change notification settings
Fork26.3k
Star96k

[jit] Cache node operators to speed up optimization#24827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

suo wants to merge1 commit intogh/suo/146/basefromgh/suo/146/head

Closed

[jit] Cache node operators to speed up optimization#24827

suo wants to merge1 commit intogh/suo/146/basefromgh/suo/146/head

Conversation

Copy link

Member

suo commentedAug 19, 2019•
edited
Loading

Stack fromghstack:

[jit] Cache node operators to speed up optimization #24827 [jit] Cache node operators to speed up optimization

We already cache the node's schema, but alias analysis wants operators.
This ends up being almost 70% of the on-cpu time optimizing a large
graph.

Here's some results on asample model
(the units are seconds).

Before:

compiled in:  20.256319999694824first run in:  313.77824568748474

After:

compiled in:  18.8815860748291first run in:  42.58739233016968

More than a 7x speedup! Still slower than I'd like though so I'll keep
digging.

Differential Revision:D16887540

[jit] Cache node operators to speed up optimization

c8a8577

We already cache the node's schema, but alias analysis wants operators.This ends up being almost 70% of the on-cpu time optimizing a largegraph.Here's some results on a [samplemodel](https://gist.github.com/suo/63ab9638516002176f94553a37060f61)(the units are seconds).Before:```compiled in:  20.256319999694824first run in:  313.77824568748474```After:```compiled in:  18.8815860748291first run in:  42.58739233016968```More than a 7x speedup! Still slower than I'd like though so I'll keepdigging.

pytorchbot added the oncall: jitAdd this issue/PR to JIT oncall triage queue label

Aug 19, 2019

suo added a commit that referenced this pull request

Aug 19, 2019

[jit] Cache node operators to speed up optimization

76f34a3

We already cache the node's schema, but alias analysis wants operators.This ends up being almost 70% of the on-cpu time optimizing a largegraph.Here's some results on a [samplemodel](https://gist.github.com/suo/63ab9638516002176f94553a37060f61)(the units are seconds).Before:```compiled in:  20.256319999694824first run in:  313.77824568748474```After:```compiled in:  18.8815860748291first run in:  42.58739233016968```More than a 7x speedup! Still slower than I'd like though so I'll keepdigging.ghstack-source-id:4d524dcPull Requestresolved:#24827