Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add logical_not operator.#23839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
xuhdev wants to merge19 commits intogh/xuhdev/18/basefromgh/xuhdev/18/head
Closed

Conversation

@xuhdev
Copy link
Collaborator

@xuhdevxuhdev commentedAug 5, 2019•
edited
Loading

Stack fromghstack:

Close#23836

Pull Requestresolved:#23839

Differential Revision:D16678301

@pytorchbotpytorchbot added module: cpuCPU specific problem (e.g., perf, algorithm) module: cudaRelated to torch.cuda, and CUDA support in general module: docsRelated to our documentation, both in docs/ and docblocks module: internalsRelated to internal abstractions in c10 and ATen module: operators labelsAug 5, 2019
@xuhdevxuhdev requested a review fromgchananAugust 5, 2019 23:27
@xuhdevxuhdev mentioned this pull requestAug 6, 2019
xuhdev added a commit that referenced this pull requestAug 6, 2019
xuhdev added a commit that referenced this pull requestAug 6, 2019
@xuhdevxuhdev requested a review fromgchananAugust 6, 2019 18:20
@gchanangchanan added this to the1.2 milestoneAug 6, 2019
xuhdev added a commit that referenced this pull requestAug 6, 2019
xuhdev added a commit that referenced this pull requestAug 6, 2019
@xuhdevxuhdev requested a review fromgchananAugust 6, 2019 18:58
xuhdev added a commit that referenced this pull requestAug 6, 2019
xuhdev added a commit that referenced this pull requestAug 7, 2019
@gchanan
Copy link
Contributor

@xuhdev: are all your recent changes to this stack just merges/rebases? I need to know if landing a prior version is safe.

also, can you stop merging/rebasing? I already checked that the failures weren't related to this diff, and we have some internal systems that will reject commits if the version we are trying to merge isn't up-to-date with the the PR. I'm not sure if the merges will go through now or I'll have to do redo it.

I realize we have no automated communication on this state so this is totally invisible to you, sorry about that!

@xuhdev
Copy link
CollaboratorAuthor

@gchanan Yes, I just rebased this morning, in case there's any conflict. Sorry for the confusion!

@gchanan
Copy link
Contributor

ok, I think it makes the most sense to punt on getting this into v1.2 -- mainly because we can't land anything right now.

@gchanangchanan removed this from the1.2 milestoneAug 7, 2019
@gchanan
Copy link
Contributor

Also, no need to apologize -- thanks so much for your contributions, they are really great.

@xuhdev
Copy link
CollaboratorAuthor

@gchanan No problem! Thanks for your review!

xuhdev added a commit that referenced this pull requestAug 12, 2019
xuhdev added a commit that referenced this pull requestAug 12, 2019
xuhdev added a commit that referenced this pull requestAug 12, 2019
xuhdev added a commit that referenced this pull requestAug 12, 2019
xuhdev added a commit that referenced this pull requestAug 13, 2019
xuhdev added a commit that referenced this pull requestAug 14, 2019
@zou3519zou3519 deleted the gh/xuhdev/18/head branchAugust 15, 2019 15:43
zdevito pushed a commit to zdevito/ATen that referenced this pull requestAug 15, 2019
Summary:Pull Requestresolved:pytorch/pytorch#23839Close #23836Pull Requestresolved:pytorch/pytorch#23839Test Plan: Imported from OSSDifferential Revision: D16678301Pulled By: gchananfbshipit-source-id: 54e7b3f3b04c577e239b88493247e1c036266774
@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in1f4c736.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gchanangchanangchanan approved these changes

Assignees

No one assigned

Labels

Mergedmodule: cpuCPU specific problem (e.g., perf, algorithm)module: cudaRelated to torch.cuda, and CUDA support in generalmodule: docsRelated to our documentation, both in docs/ and docblocksmodule: internalsRelated to internal abstractions in c10 and ATenopen source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xuhdev@gchanan@facebook-github-bot@ezyang@pytorchbot@mruberry
[8]ページ先頭
©2009-2025 Movatter.jp