Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[ROCm] Enable multiple NestedTensor tests on ROCm#170829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
FIM43-Redeye wants to merge1 commit intopytorch:main
base:main
Choose a base branch
Loading
fromFIM43-Redeye:fix-rocm-168785

Conversation

@FIM43-Redeye
Copy link

@FIM43-RedeyeFIM43-Redeye commentedDec 19, 2025•
edited
Loading

This PR enables several NestedTensor tests (SDPA, compile, and error index) that now pass on ROCm 7.1.

Fixes#168785
Fixes#168786
Fixes#168787
Fixes#168788
Fixes#168789
Fixes#168790
Fixes#168792
Fixes#168793
Fixes#168794
Fixes#168795
Fixes#168796
Fixes#168797

cc@jeffdaily@sunway513@jithunnair-amd@pruthvistony@ROCmSupport@jataylo@hongxiayang@naromero77amd@pragupta@jerrymannil@xinyazhang

CopilotAI review requested due to automatic review settingsDecember 19, 2025 00:05
@pytorch-bot
Copy link

pytorch-botbot commentedDec 19, 2025•
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results athud.pytorch.org/pr/170829

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR enables thetest_index_put_error test for ROCm by removing an outdated skip decorator. The skip was originally in place because ROCm disabled kernel assertions for performance reasons, but ROCm 7.1 now correctly raises errors on invalid index operations, allowing the test to pass.

Key Changes:

  • Removed@unittest.skipIf(TEST_WITH_ROCM, ...) decorator fromtest_index_put_error method

This commit enables several NestedTensor tests (SDPA, compile, and error index)that now pass on ROCm 7.1.Fixespytorch#168785Fixespytorch#168786Fixespytorch#168787Fixespytorch#168788Fixespytorch#168789Fixespytorch#168790Fixespytorch#168792Fixespytorch#168793Fixespytorch#168794Fixespytorch#168795Fixespytorch#168796Fixespytorch#168797
@FIM43-RedeyeFIM43-Redeye changed the title[ROCm] Enable test_index_put_error for NestedTensor[ROCm] Enable multiple NestedTensor tests on ROCmDec 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Labels

module: rocmAMD GPU support for Pytorchopen sourcetopic: not user facingtopic category

Projects

None yet

Milestone

No milestone

2 participants

@FIM43-Redeye@pytorchbot
[8]ページ先頭
©2009-2025 Movatter.jp